Skip to content

Commit cc547c9

Browse files
davidbennebeid
authored andcommitted
Remove X509_REQ's refcount.
We have no X509_REQ_up_ref function, and neither does OpenSSL. That means this reference count is unreachable, so remove it. Change-Id: I6a0899b8fcb0716d47c89174b561e90d99a9b54b Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/53306 Reviewed-by: Bob Beck <[email protected]> Commit-Queue: David Benjamin <[email protected]> (cherry picked from commit f022e8421b927296d50436ae7b4b54fa4019cf41)
1 parent 1dbb5a6 commit cc547c9

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

crypto/x509/internal.h

-1
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,6 @@ struct X509_req_st {
181181
X509_REQ_INFO *req_info;
182182
X509_ALGOR *sig_alg;
183183
ASN1_BIT_STRING *signature;
184-
CRYPTO_refcount_t references;
185184
} /* X509_REQ */;
186185

187186
struct x509_revoked_st {

crypto/x509/x_req.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -105,11 +105,11 @@ ASN1_SEQUENCE_enc(X509_REQ_INFO, enc, rinf_cb) = {
105105

106106
IMPLEMENT_ASN1_FUNCTIONS(X509_REQ_INFO)
107107

108-
ASN1_SEQUENCE_ref(X509_REQ, 0) = {
108+
ASN1_SEQUENCE(X509_REQ) = {
109109
ASN1_SIMPLE(X509_REQ, req_info, X509_REQ_INFO),
110110
ASN1_SIMPLE(X509_REQ, sig_alg, X509_ALGOR),
111111
ASN1_SIMPLE(X509_REQ, signature, ASN1_BIT_STRING),
112-
} ASN1_SEQUENCE_END_ref(X509_REQ, X509_REQ)
112+
} ASN1_SEQUENCE_END(X509_REQ)
113113

114114
IMPLEMENT_ASN1_FUNCTIONS(X509_REQ)
115115

0 commit comments

Comments
 (0)