Skip to content

Commit 94c3074

Browse files
davidbenjustsmth
authored andcommitted
Document APIs relating to built-in and custom extensions
While I'm here, unexport STACK_OF(X509V3_EXT_METHOD). We use it internally, but it never appears in any public APIs, and there's no real reason for any caller to use it. Bug: 426 Change-Id: I6057834847a37f435d1b687701a3e65b5afb2890 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/66387 Auto-Submit: David Benjamin <[email protected]> Commit-Queue: Bob Beck <[email protected]> Reviewed-by: Bob Beck <[email protected]> (cherry picked from commit 9d7535f51f84a079c05b27134fcf6111649c56c9)
1 parent e4e6bea commit 94c3074

File tree

3 files changed

+283
-233
lines changed

3 files changed

+283
-233
lines changed

crypto/x509/v3_lib.c

+2
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,8 @@
7070

7171
#include "ext_dat.h"
7272

73+
DEFINE_STACK_OF(X509V3_EXT_METHOD)
74+
7375
static STACK_OF(X509V3_EXT_METHOD) *ext_list = NULL;
7476

7577
static int ext_stack_cmp(const X509V3_EXT_METHOD *const *a,

include/openssl/obj.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -194,8 +194,8 @@ OPENSSL_EXPORT int OBJ_obj2txt(char *out, int out_len, const ASN1_OBJECT *obj,
194194
// duplicate OIDs, short names, or long names. If two callers in the same
195195
// address space add conflicting values, only one registration will take effect.
196196
// Avoid this function if possible. Instead, callers can process OIDs unknown to
197-
// BoringSSL by acting on the byte representation directly. See |OBJ_get0_data|
198-
// and |OBJ_length|.
197+
// BoringSSL by acting on the byte representation directly. See
198+
// |ASN1_OBJECT_create|, |OBJ_get0_data|, and |OBJ_length|.
199199
OPENSSL_EXPORT int OBJ_create(const char *oid, const char *short_name,
200200
const char *long_name);
201201

0 commit comments

Comments
 (0)