Skip to content

Commit 7d9d756

Browse files
committedJan 22, 2015
configure: disable vfpv3 on armv6
VFPv3 is ARMv7-only, enabling it for ARMv6 is therefore always wrong. Mea culpa, I do believe I'm the original author of that change. Fixes: nodejs#283 PR-URL: nodejs#559 Reviewed-By: Fedor Indutny <[email protected]>
1 parent 297cadb commit 7d9d756

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed
 

‎configure

+5-5
Original file line numberDiff line numberDiff line change
@@ -468,14 +468,14 @@ def configure_arm(o):
468468
arm_float_abi = 'default'
469469

470470
if is_arch_armv7():
471+
o['variables']['arm_fpu'] = 'vfpv3'
472+
o['variables']['arm_neon'] = int(is_arm_neon())
471473
o['variables']['arm_version'] = '7'
472-
elif is_arch_armv6():
473-
o['variables']['arm_version'] = '6'
474474
else:
475-
o['variables']['arm_version'] = 'default'
475+
o['variables']['arm_fpu'] = 'vfpv2'
476+
o['variables']['arm_neon'] = 0
477+
o['variables']['arm_version'] = '6' if is_arch_armv6() else 'default'
476478

477-
o['variables']['arm_fpu'] = 'vfpv3' # V8 3.18 no longer supports VFP2.
478-
o['variables']['arm_neon'] = int(is_arm_neon())
479479
o['variables']['arm_thumb'] = 0 # -marm
480480
o['variables']['arm_float_abi'] = arm_float_abi
481481

0 commit comments

Comments
 (0)
Please sign in to comment.