Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for windows arm64 cmake? #165

Closed
hjyamauchi opened this issue Dec 19, 2024 · 8 comments
Closed

Support for windows arm64 cmake? #165

hjyamauchi opened this issue Dec 19, 2024 · 8 comments

Comments

@hjyamauchi
Copy link

Hi @lukka,

Is there a chance that the windows arm64 cmake packages are added to the catalog?

For example, https://github.com/Kitware/CMake/releases/tag/v3.28.6 has https://github.com/Kitware/CMake/releases/download/v3.28.6/cmake-3.28.6-windows-arm64.zip

Thanks,
Hiroshi

@lukka
Copy link
Owner

lukka commented Dec 19, 2024

@hjyamauchi please test this out: #166
I haven't tested it at all, feel free also to create another PR based on that one, or just let me know what does not work.

@hjyamauchi
Copy link
Author

@lukka That worked for me! It'd be great if you can merge it.

@lukka
Copy link
Owner

lukka commented Dec 21, 2024

@hjyamauchi, could you provide some evidence to show how it worked? Specifically, I'd like to confirm that the ARM64 executable was run instead of the x64 version. Verifying this would be easier with a hosted ARM64 agent, but since there isn't one available (as far as I know), I'd appreciate seeing some log excerpts or other details before we proceed with the change. Thanks!

@hjyamauchi
Copy link
Author

@lukka I tested it in an internal CI running on a self-hosted win/arm64 runner that needs to override the version of cmake due to a cmake bug based on my fork of get-cmake with #166 patched in. I know this is working because if it doesn't override, the cmake bug would cause a build failure later, which it didn't.

Here's what the workflow step looks like:

      - uses: hjyamauchi/get-cmake@main
        with:
          cmakeVersion: 3.28.6

Here's the raw log:

Run hjyamauchi/get-cmake@main
useCloudCache:true
useLocalCache:false
user defined cmake version:3.28.6
user defined ninja version:
cmake version:3.28.6
ninja version:latest
Computing cache key from the downloads' URLs
Restoring from GitHub cloud cache using key '858378870' into 'D:\r\_work\_temp\858378870'
  Cache Size: ~36 MB (38[1](https://github.com/thebrowsercompany/swift-build/actions/runs/12426278086/job/34697342162#step:20:1)45323 B)
  "C:\Program Files\Git\usr\bin\tar.exe" -xf D:/r/_work/_temp/ff8d29ca-ba31-4e3a-889c-350be3b0b252/cache.tgz -P -C D:/r/_work/swift-build/swift-build --force-local -z
  Received 38145323 of 38145323 (100.0%), 36.2 MBs/sec
  Cache restored successfully
  Cloud cache hit.
Add CMake and Ninja to PATH
  CMake path: 'D:\r\_work\_temp\8[58](https://github.com/thebrowsercompany/swift-build/actions/runs/12426278086/job/34697342162#step:20:59)378870\cmake-3.28.6-windows-arm64\bin\'
  Ninja path: 'D:\r\_work\_temp\858378870'
Validating the installed CMake and Ninja
  CMake actual path is: 'D:\r\_work\_temp\858378870\cmake-3.28.6-windows-arm[64](https://github.com/thebrowsercompany/swift-build/actions/runs/12426278086/job/34697342162#step:20:66)\bin\cmake.exe'
  Ninja actual path is: 'D:\r\_work\_temp\858378870\ninja.exe'

get-cmake action execution succeeded

@lukka
Copy link
Owner

lukka commented Dec 22, 2024

@hjyamauchi ok, could you please test get-cmake@main. If that is working, then I'll release it.

@hjyamauchi
Copy link
Author

@lukka It worked fine in the same setup.

      - uses: lukka/get-cmake@main
        with:
          cmakeVersion: 3.28.6
Run lukka/get-cmake@main
useCloudCache:true
useLocalCache:false
user defined cmake version:3.28.6
user defined ninja version:
cmake version:3.28.6
ninja version:latest
Computing cache key from the downloads' URLs
Restoring from GitHub cloud cache using key '858378870' into 'D:\r\_work\_temp\858378870'
  Cache Size: ~36 MB (38[1](https://github.com/thebrowsercompany/swift-build/actions/runs/12458227804/job/34775119077#step:21:1)44563 B)
  "C:\Program Files\Git\usr\bin\tar.exe" -xf D:/r/_work/_temp/3eccf67b-790a-4b7c-9[54](https://github.com/thebrowsercompany/swift-build/actions/runs/12458227804/job/34775119077#step:21:55)e-5a8bcb2464d2/cache.tgz -P -C D:/r/_work/swift-build/swift-build --force-local -z
  Received 38144[56](https://github.com/thebrowsercompany/swift-build/actions/runs/12458227804/job/34775119077#step:21:57)3 of 38144563 (100.0%), 35.8 MBs/sec
  Cache restored successfully
  Cloud cache hit.
Add CMake and Ninja to PATH
  CMake path: 'D:\r\_work\_temp\8[58](https://github.com/thebrowsercompany/swift-build/actions/runs/12458227804/job/34775119077#step:21:59)378870\cmake-3.28.6-windows-arm64\bin\'
  Ninja path: 'D:\r\_work\_temp\858378870'
Validating the installed CMake and Ninja
  CMake actual path is: 'D:\r\_work\_temp\858378870\cmake-3.28.6-windows-arm[64](https://github.com/thebrowsercompany/swift-build/actions/runs/12458227804/job/34775119077#step:21:66)\bin\cmake.exe'
  Ninja actual path is: 'D:\r\_work\_temp\858378870\ninja.exe'

get-cmake action execution succeeded

@lukka
Copy link
Owner

lukka commented Dec 23, 2024

@hjyamauchi thank you for the support and suggestion!
Released with https://github.com/lukka/get-cmake/releases/tag/fix-issue-165.

@lukka lukka closed this as completed Dec 23, 2024
@hjyamauchi
Copy link
Author

@lukka Thank you for adding this support. Highly appreciate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants