Skip to content

Commit 0fc789f

Browse files
committed
getFieldValue() should return the value of fieldValue without transforming it into a String
`ObjectAppendingMarker#getFieldValue()` should ideally return the value of the `fieldValue` property without transformation. This method is intended to be used by `SingleFieldAppendingMarker#tselfToString()` that already takes care of converting the value into a String. closes #719
1 parent 6c92cb4 commit 0fc789f

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/main/java/net/logstash/logback/marker/ObjectAppendingMarker.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ protected void writeFieldValue(JsonGenerator generator) throws IOException {
9494
}
9595

9696
@Override
97-
public Object getFieldValue() {
98-
return StructuredArguments.toString(fieldValue);
97+
protected Object getFieldValue() {
98+
return fieldValue;
9999
}
100100

101101
@Override

src/main/java/net/logstash/logback/marker/RawJsonAppendingMarker.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ protected void writeFieldValue(JsonGenerator generator) throws IOException {
6666
}
6767

6868
@Override
69-
public Object getFieldValue() {
69+
protected Object getFieldValue() {
7070
return rawJson;
7171
}
7272

src/main/java/net/logstash/logback/marker/SingleFieldAppendingMarker.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ public String toStringSelf() {
129129
*
130130
* @return the field value
131131
*/
132-
public abstract Object getFieldValue();
132+
protected abstract Object getFieldValue();
133133

134134
@Override
135135
public boolean equals(Object obj) {

0 commit comments

Comments
 (0)