fix: tilde expansion

Author: lamweili

lib/RollingFileWriteStream.js

@@ -43,10 +43,10 @@ class RollingFileWriteStream extends Writable {
       throw new Error(`Invalid filename: ${filePath}`);
     } else if (filePath.endsWith(path.sep)) {
       throw new Error(`Filename is a directory: ${filePath}`);
-    } else {
+    } else if (filePath.indexOf(`~${path.sep}`) === 0) {
       // handle ~ expansion: https://github.com/nodejs/node/issues/684
       // exclude ~ and ~filename as these can be valid files
-      filePath = filePath.replace(new RegExp(`^~(?=${path.sep}.+)`), os.homedir());
+      filePath = filePath.replace("~", os.homedir());
     }
     super(options);
     this.options = this._parseOption(options);

test/RollingFileWriteStream-test.js

@@ -89,6 +89,33 @@ describe("RollingFileWriteStream", () => {
     });
   });
 
+  describe("with tilde expansion in filename", () => {   
+    let s;
+    const fileName = "tmpTilde.log";
+    const expandedPath = path.join(__dirname, fileName)
+
+    before(() => {
+      const RollingFileWriteStream = proxyquire("../lib/RollingFileWriteStream", {
+        "./now": mockNow,
+        "os": {
+          homedir() {
+            return path.join(__dirname);
+          } 
+        }
+      });
+      s = new RollingFileWriteStream(path.join("~", fileName));
+    });
+
+    after(() => {
+      s.end(() => fs.removeSync(expandedPath));
+    });
+
+    it("should take a filename and options, return Writable", async () => {
+      s.currentFileStream.path.should.eql(expandedPath);
+      fs.existsSync(expandedPath).should.be.true();
+    });
+  });
+
   describe("with default arguments", () => {
     const fileObj = generateTestFile();
     let s;
@@ -341,7 +368,7 @@ describe("RollingFileWriteStream", () => {
       s.end(() => {
         fs.removeSync(fileObj.dir);
         done();
-      })
+      });
     });
 
     it("should rotate files within the day, and when the day changes", () => {