Skip to content

Commit d4eed43

Browse files
authoredJun 8, 2024··
Enable LLDB tests in Linux pre-merge CI (#94208)
This patch removes LLDB from a list of projects that are excluded from building and testing on pre-merge CI on Linux. Windows environment needs to be prepared in order to test LLDB (#94208 (comment)), but we don't have enough maintenance resources to do that at the moment. Because LLDB has been in the list of projects that need to be tested on Clang changes, this PR make this happen on Linux. This seems to be the consensus in the discussion of this PR.
1 parent 82f6cde commit d4eed43

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed
 

‎.ci/generate-buildkite-pipeline-premerge

+2-3
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,6 @@ function exclude-linux() {
153153
for project in ${projects}; do
154154
case ${project} in
155155
cross-project-tests) ;; # tests failing
156-
lldb) ;; # tests failing
157156
openmp) ;; # https://github.com/google/llvm-premerge-checks/issues/410
158157
*)
159158
echo "${project}"
@@ -170,7 +169,7 @@ function exclude-windows() {
170169
compiler-rt) ;; # tests taking too long
171170
openmp) ;; # TODO: having trouble with the Perl installation
172171
libc) ;; # no Windows support
173-
lldb) ;; # tests failing
172+
lldb) ;; # custom environment requirements (https://github.com/llvm/llvm-project/pull/94208#issuecomment-2146256857)
174173
bolt) ;; # tests are not supported yet
175174
*)
176175
echo "${project}"
@@ -213,7 +212,7 @@ function check-targets() {
213212
echo "check-unwind"
214213
;;
215214
lldb)
216-
echo "check-all" # TODO: check-lldb may not include all the LLDB tests?
215+
echo "check-lldb"
217216
;;
218217
pstl)
219218
echo "check-all"

‎.ci/monolithic-linux.sh

+1
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ targets="${2}"
3939

4040
echo "--- cmake"
4141
pip install -q -r "${MONOREPO_ROOT}"/mlir/python/requirements.txt
42+
pip install -q -r "${MONOREPO_ROOT}"/lldb/test/requirements.txt
4243
cmake -S "${MONOREPO_ROOT}"/llvm -B "${BUILD_DIR}" \
4344
-D LLVM_ENABLE_PROJECTS="${projects}" \
4445
-G Ninja \

‎clang/examples/PrintFunctionNames/PrintFunctionNames.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ class PrintFunctionsConsumer : public ASTConsumer {
7272
*sema.LateParsedTemplateMap.find(FD)->second;
7373
sema.LateTemplateParser(sema.OpaqueParser, LPT);
7474
llvm::errs() << "late-parsed-decl: \"" << FD->getNameAsString() << "\"\n";
75-
}
75+
}
7676
}
7777
};
7878

0 commit comments

Comments
 (0)
Please sign in to comment.