Skip to content

Commit c72389d

Browse files
authoredNov 8, 2024··
[clang][CIR] Merge the mlir::cir namespace into cir (#115386)
llvm/clangir#1025 discusses the motivation. The mechanical parts of this change were done via: find clang \( -name '*.h' -o -name '*.cpp' -o -name '*.td' \) -print0 | xargs -0 perl -pi -e 's/mlir::cir/cir/g' find clang \( -name '*.h' -o -name '*.cpp' \) -print0 | xargs -0 perl -pi -e 's/::cir/cir/g' There were some manual fixups and a clang-format run afterwards.
1 parent 40e5450 commit c72389d

File tree

8 files changed

+22
-20
lines changed

8 files changed

+22
-20
lines changed
 

‎clang/include/clang/CIR/Dialect/IR/CIRDialect.td

+8-6
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def CIR_Dialect : Dialect {
2222
let summary = "A high-level dialect for analyzing and optimizing Clang "
2323
"supported languages";
2424

25-
let cppNamespace = "::mlir::cir";
25+
let cppNamespace = "::cir";
2626

2727
let useDefaultAttributePrinterParser = 0;
2828
let useDefaultTypePrinterParser = 0;
@@ -31,13 +31,15 @@ def CIR_Dialect : Dialect {
3131
void registerAttributes();
3232
void registerTypes();
3333

34-
Type parseType(DialectAsmParser &parser) const override;
35-
void printType(Type type, DialectAsmPrinter &printer) const override;
34+
mlir::Type parseType(mlir::DialectAsmParser &parser) const override;
35+
void printType(mlir::Type type,
36+
mlir::DialectAsmPrinter &printer) const override;
3637

37-
Attribute parseAttribute(DialectAsmParser &parser,
38-
Type type) const override;
38+
mlir::Attribute parseAttribute(mlir::DialectAsmParser &parser,
39+
mlir::Type type) const override;
3940

40-
void printAttribute(Attribute attr, DialectAsmPrinter &os) const override;
41+
void printAttribute(mlir::Attribute attr,
42+
mlir::DialectAsmPrinter &os) const override;
4143
}];
4244
}
4345

‎clang/include/clang/CIR/Dialect/IR/CIROps.td

+4-4
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,12 @@ include "mlir/Interfaces/SideEffectInterfaces.td"
5151
// following:
5252
//
5353
// class CIRFooOpLowering
54-
// : public mlir::OpConversionPattern<mlir::cir::FooOp> {
54+
// : public mlir::OpConversionPattern<cir::FooOp> {
5555
// public:
56-
// using OpConversionPattern<mlir::cir::FooOp>::OpConversionPattern;
56+
// using OpConversionPattern<cir::FooOp>::OpConversionPattern;
5757
//
5858
// mlir::LogicalResult matchAndRewrite(
59-
// mlir::cir::FooOp op,
59+
// cir::FooOp op,
6060
// OpAdaptor adaptor,
6161
// mlir::ConversionPatternRewriter &rewriter) const override {
6262
// rewriter.replaceOpWithNewOp<mlir::LLVM::BarOp>(
@@ -92,7 +92,7 @@ def FuncOp : CIR_Op<"func"> {
9292

9393
let skipDefaultBuilders = 1;
9494

95-
let builders = [OpBuilder<(ins "StringRef":$name)>];
95+
let builders = [OpBuilder<(ins "llvm::StringRef":$name)>];
9696

9797
let hasCustomAssemblyFormat = 1;
9898
let hasVerifier = 1;

‎clang/lib/CIR/CodeGen/CIRGenModule.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ void CIRGenModule::buildGlobal(clang::GlobalDecl gd) {
7777
void CIRGenModule::buildGlobalFunctionDefinition(clang::GlobalDecl gd,
7878
mlir::Operation *op) {
7979
auto const *funcDecl = cast<FunctionDecl>(gd.getDecl());
80-
auto funcOp = builder.create<mlir::cir::FuncOp>(
80+
auto funcOp = builder.create<cir::FuncOp>(
8181
getLoc(funcDecl->getSourceRange()), funcDecl->getIdentifier()->getName());
8282
theModule.push_back(funcOp);
8383
}

‎clang/lib/CIR/CodeGen/CIRGenerator.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ void CIRGenerator::Initialize(ASTContext &astCtx) {
3535
this->astCtx = &astCtx;
3636

3737
mlirCtx = std::make_unique<mlir::MLIRContext>();
38-
mlirCtx->loadDialect<mlir::cir::CIRDialect>();
38+
mlirCtx->loadDialect<cir::CIRDialect>();
3939
cgm = std::make_unique<clang::CIRGen::CIRGenModule>(*mlirCtx.get(), astCtx,
4040
codeGenOpts, diags);
4141
}

‎clang/lib/CIR/Dialect/IR/CIRAttrs.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
#include "clang/CIR/Dialect/IR/CIRDialect.h"
1414

1515
using namespace mlir;
16-
using namespace mlir::cir;
16+
using namespace cir;
1717

1818
//===----------------------------------------------------------------------===//
1919
// General CIR parsing / printing

‎clang/lib/CIR/Dialect/IR/CIRDialect.cpp

+5-5
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@
1717
#include "clang/CIR/Dialect/IR/CIROpsDialect.cpp.inc"
1818

1919
using namespace mlir;
20-
using namespace mlir::cir;
20+
using namespace cir;
2121

2222
//===----------------------------------------------------------------------===//
2323
// CIR Dialect
2424
//===----------------------------------------------------------------------===//
2525

26-
void mlir::cir::CIRDialect::initialize() {
26+
void cir::CIRDialect::initialize() {
2727
registerTypes();
2828
registerAttributes();
2929
addOperations<
@@ -36,8 +36,8 @@ void mlir::cir::CIRDialect::initialize() {
3636
// FuncOp
3737
//===----------------------------------------------------------------------===//
3838

39-
void mlir::cir::FuncOp::build(OpBuilder &builder, OperationState &result,
40-
StringRef name) {
39+
void cir::FuncOp::build(OpBuilder &builder, OperationState &result,
40+
StringRef name) {
4141
result.addAttribute(SymbolTable::getSymbolAttrName(),
4242
builder.getStringAttr(name));
4343
}
@@ -56,7 +56,7 @@ void cir::FuncOp::print(OpAsmPrinter &p) {
5656
p.printSymbolName(getSymName());
5757
}
5858

59-
mlir::LogicalResult mlir::cir::FuncOp::verify() { return success(); }
59+
mlir::LogicalResult cir::FuncOp::verify() { return success(); }
6060

6161
//===----------------------------------------------------------------------===//
6262
// TableGen'd op method definitions

‎clang/lib/CIR/Dialect/IR/CIRTypes.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
#include "clang/CIR/Dialect/IR/CIRDialect.h"
1414

1515
using namespace mlir;
16-
using namespace mlir::cir;
16+
using namespace cir;
1717

1818
//===----------------------------------------------------------------------===//
1919
// General CIR parsing / printing

‎clang/lib/FrontendTool/ExecuteCompilerInvocation.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ CreateFrontendBaseAction(CompilerInstance &CI) {
6767
case EmitBC: return std::make_unique<EmitBCAction>();
6868
case EmitCIR:
6969
#if CLANG_ENABLE_CIR
70-
return std::make_unique<::cir::EmitCIRAction>();
70+
return std::make_unique<cir::EmitCIRAction>();
7171
#else
7272
llvm_unreachable("CIR suppport not built into clang");
7373
#endif

0 commit comments

Comments
 (0)
Please sign in to comment.