Skip to content

Commit 4cdfa2a

Browse files
committedNov 14, 2024·
[OpenACC] Fix test that didn't actually test the clause it claimed to
Apparently a copy/paste issue, we were testing private instead of firstprivate for oen of the tests.
1 parent d84d0ca commit 4cdfa2a

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed
 

‎clang/test/SemaOpenACC/compute-construct-firstprivate-clause.cpp

+11-11
Original file line numberDiff line numberDiff line change
@@ -60,34 +60,34 @@ void uses(int IntParam, char *PointerParam, float ArrayParam[5], Complete Compos
6060
template<typename T, unsigned I, typename V>
6161
void TemplUses(T t, T (&arrayT)[I], V TemplComp) {
6262
// expected-error@+1{{OpenACC variable is not a valid variable name, sub-array, array element, member of a composite variable, or composite variable member}}
63-
#pragma acc parallel private(+t)
63+
#pragma acc parallel firstprivate(+t)
6464
while(true);
6565

6666
// NTTP's are only valid if it is a reference to something.
6767
// expected-error@+2{{OpenACC variable is not a valid variable name, sub-array, array element, member of a composite variable, or composite variable member}}
6868
// expected-note@#TEMPL_USES_INST{{in instantiation of}}
69-
#pragma acc parallel private(I)
69+
#pragma acc parallel firstprivate(I)
7070
while(true);
7171

7272
// expected-error@+1{{OpenACC variable is not a valid variable name, sub-array, array element, member of a composite variable, or composite variable member}}
73-
#pragma acc parallel private(t, I)
73+
#pragma acc parallel firstprivate(t, I)
7474
while(true);
7575

76-
#pragma acc parallel private(arrayT)
76+
#pragma acc parallel firstprivate(arrayT)
7777
while(true);
7878

79-
#pragma acc parallel private(TemplComp)
79+
#pragma acc parallel firstprivate(TemplComp)
8080
while(true);
8181

82-
#pragma acc parallel private(TemplComp.PointerMember[5])
82+
#pragma acc parallel firstprivate(TemplComp.PointerMember[5])
8383
while(true);
8484
int *Pointer;
85-
#pragma acc parallel private(Pointer[:I])
85+
#pragma acc parallel firstprivate(Pointer[:I])
8686
while(true);
87-
#pragma acc parallel private(Pointer[:t])
87+
#pragma acc parallel firstprivate(Pointer[:t])
8888
while(true);
8989
// expected-error@+1{{OpenACC sub-array length is unspecified and cannot be inferred because the subscripted value is not an array}}
90-
#pragma acc parallel private(Pointer[1:])
90+
#pragma acc parallel firstprivate(Pointer[1:])
9191
while(true);
9292
}
9393

@@ -96,10 +96,10 @@ void NTTP() {
9696
// NTTP's are only valid if it is a reference to something.
9797
// expected-error@+2{{OpenACC variable is not a valid variable name, sub-array, array element, member of a composite variable, or composite variable member}}
9898
// expected-note@#NTTP_INST{{in instantiation of}}
99-
#pragma acc parallel private(I)
99+
#pragma acc parallel firstprivate(I)
100100
while(true);
101101

102-
#pragma acc parallel private(NTTP_REF)
102+
#pragma acc parallel firstprivate(NTTP_REF)
103103
while(true);
104104
}
105105

0 commit comments

Comments
 (0)
Please sign in to comment.