Skip to content

Commit 467a9bd

Browse files
authoredOct 16, 2024
[polly] Avoid llvm::Type::getPointerTo() (NFC) (#112368)
`llvm::Type::getPointerTo()` is to be deprecated & removed soon. Also, avoid pointercasts that are essentially no-ops.
1 parent 7033408 commit 467a9bd

File tree

3 files changed

+1
-9
lines changed

3 files changed

+1
-9
lines changed
 

‎polly/lib/CodeGen/BlockGenerators.cpp

-6
Original file line numberDiff line numberDiff line change
@@ -786,12 +786,6 @@ void BlockGenerator::generateScalarStores(
786786
Builder.GetInsertBlock())) &&
787787
"Domination violation");
788788

789-
// The new Val might have a different type than the old Val due to
790-
// ScalarEvolution looking through bitcasts.
791-
Address = Builder.CreateBitOrPointerCast(
792-
Address, Val->getType()->getPointerTo(
793-
Address->getType()->getPointerAddressSpace()));
794-
795789
Builder.CreateStore(Val, Address);
796790
});
797791
}

‎polly/lib/CodeGen/IslNodeBuilder.cpp

-2
Original file line numberDiff line numberDiff line change
@@ -1050,8 +1050,6 @@ Value *IslNodeBuilder::preloadUnconditionally(__isl_take isl_set *AccessRange,
10501050

10511051
auto *Ptr = AddressValue;
10521052
auto Name = Ptr->getName();
1053-
auto AS = Ptr->getType()->getPointerAddressSpace();
1054-
Ptr = Builder.CreatePointerCast(Ptr, Ty->getPointerTo(AS), Name + ".cast");
10551053
PreloadVal = Builder.CreateLoad(Ty, Ptr, Name + ".load");
10561054
if (LoadInst *PreloadInst = dyn_cast<LoadInst>(PreloadVal))
10571055
PreloadInst->setAlignment(cast<LoadInst>(AccInst)->getAlign());

‎polly/lib/CodeGen/LoopGeneratorsGOMP.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ Value *ParallelLoopGeneratorGOMP::createCallGetWorkItem(Value *LBPtr,
183183
// If F is not available, declare it.
184184
if (!F) {
185185
GlobalValue::LinkageTypes Linkage = Function::ExternalLinkage;
186-
Type *Params[] = {LongType->getPointerTo(), LongType->getPointerTo()};
186+
Type *Params[] = {Builder.getPtrTy(0), Builder.getPtrTy(0)};
187187
FunctionType *Ty = FunctionType::get(Builder.getInt8Ty(), Params, false);
188188
F = Function::Create(Ty, Linkage, Name, M);
189189
}

0 commit comments

Comments
 (0)