Skip to content

Commit 8a3b6ca

Browse files
committed
add some comments
1 parent b2af972 commit 8a3b6ca

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

clang/lib/CIR/CodeGen/CIRGenBuilder.h

+1
Original file line numberDiff line numberDiff line change
@@ -417,6 +417,7 @@ class CIRGenBuilderTy : public CIRBaseBuilderTy {
417417

418418
// Fetch the type representing a pointer to unsigned int values.
419419
mlir::cir::PointerType getUInt8PtrTy(unsigned AddrSpace = 0) {
420+
// If zero address space, it's already cached.
420421
if (AddrSpace == 0)
421422
return typeCache.UInt8PtrTy;
422423
return mlir::cir::PointerType::get(getContext(), typeCache.UInt8Ty,

clang/lib/CIR/Dialect/Transforms/LoweringPrepare.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -526,6 +526,7 @@ static void lowerArrayDtorCtorIntoLoop(CIRBaseBuilderTy &builder,
526526
mlir::Value end = builder.create<mlir::cir::PtrStrideOp>(
527527
loc, eltTy, begin, numArrayElementsConst);
528528

529+
// TODO: fix getPointerTo(eltTy) by querying the data layout
529530
assert(!::cir::MissingFeatures::addressSpaceInAlloca());
530531
auto tmpAddr = builder.createAlloca(
531532
loc, /*addr type*/ builder.getPointerTo(eltTy),

0 commit comments

Comments
 (0)