Skip to content
This repository was archived by the owner on Jul 21, 2023. It is now read-only.

docs: fix readme.md #342

Merged
merged 3 commits into from
May 25, 2022
Merged

docs: fix readme.md #342

merged 3 commits into from
May 25, 2022

Conversation

zeim839
Copy link
Contributor

@zeim839 zeim839 commented May 24, 2022

Solves issue #324

Issues addressed:

  1. Dead Peer Routing, Content Routing, Peer discovery badge images.
  2. Dead/incorrect Open an issue... link. This now points to the js-libp2p-kad-dht issues page, instead of a dead IPFS issues page. I also felt that pointing to the local issues page rather than IPFS was more reasonable (this is what other libp2p repos tend to do).
  3. Updated contributing badge to point to new URL.

For the peer routing, etc. badges, I've linked the images to their respective deprecated and read-only repositories - this should prevent any future 404s and is what the updated libp2p-interfaces repo does. Clicking on the images will still redirect to the updated repositories.

Please note that there's still a dead URL in the dependency status badge (below the title header). The entire domain is down, so I wasn't sure what to replace it with.

That said, all other URL's/badges should now be working and updated.

Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@achingbrain achingbrain changed the title Fix/readme.md docs: fix readme.md May 25, 2022
@achingbrain achingbrain merged commit ddea70d into libp2p:master May 25, 2022
@achingbrain
Copy link
Member

Thanks!

@zeim839 zeim839 deleted the fix/readme.md branch May 25, 2022 14:35
github-actions bot pushed a commit that referenced this pull request May 25, 2022
### [1.0.15](v1.0.14...v1.0.15) (2022-05-25)

### Trivial Changes

* fix readme.md ([#342](#342)) ([ddea70d](ddea70d)), closes [#324](#324)
@github-actions
Copy link

🎉 This PR is included in version 1.0.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants