This repository was archived by the owner on Jul 21, 2023. It is now read-only.
feat: add support for client mode #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
approved these changes
Jul 10, 2020
vasco-santos
approved these changes
Jul 10, 2020
There was a problem hiding this comment.
LGTM!
We should track making this the default on libp2p/js-libp2p-kad-dht#183, or guarantee that we have autoNAT in place
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability for DHT nodes to run in client mode. This means, nodes will not register nor respond to queries on the dht protocol, which nodes should be doing if they are not dialable (browser nodes, nodes behind NATs)
Ideally, this should be dynamic and should be in client mode by default, however, js-libp2p doesn't currently have autoNat support so we can't dynamically determine our dialability.
To keep this backwards compatible clientMode is disabled by default.
I left
_clientModeas private for now. In the future we may want to add a setter to allow this to be changed dynamically.