This repository was archived by the owner on Jul 21, 2023. It is now read-only.
fix: providers leaking resources on dht construction #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
fix/providers-leaking-resources-on-dht-construction
branch
from
3602a45 to
0e5f6fd
Compare
3 tasks
jacobheun
approved these changes
Jun 5, 2020
src/providers.js
Outdated
| start () { | ||
| if (this._cleaner) { | ||
| clearInterval(this._cleaner) | ||
| } |
There was a problem hiding this comment.
The check isn't necessary in stop and start since clearInterval ignores null/undefined values.
jacobheun
deleted the
fix/providers-leaking-resources-on-dht-construction
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After debugging one
js-ipfsexample hanging, I found this leaking issue.When
js-libp2pis created, thedhtwill be created if enabled. When thedhtis enabled, it will be instantiated. During the instantiation,Providerswas also instantiated and a setter was starting a timer. If the dht was created, but not started, when a process is closing, this timer was not cleared, since the stop was also not called.