This repository was archived by the owner on Jul 21, 2023. It is now read-only.
fix: dont use peer ids in sets #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During queries, whenever a Peer is queried directly it is added to the
peersSeenSet, which prevents us from querying them again. The issue is that currentlypeerSeenis a Set ofPeerId. Whenever we learn about peers from the network, the deserialized PeerIds are created as new objects, which will cause them to be added to the set even if they belong to the same peer. This fixes that by using the string of the peer id and makingpeerSeena string Set for better equality checking.