refactor: use async datastore #140
Conversation
BREAKING CHANGE: The DHT now requires its datastore to have a promise based api, instead of callbacks. Datastores that use ipfs/[email protected] or later should be used. https://github.com/ipfs/interface-datastore/releases/tag/v0.7.0
some rules have been ignored until the full async/await migration has completed
src/rpc/handlers/get-providers.js
Outdated
| @@ -33,7 +33,7 @@ module.exports = (dht) => { | |||
| const dsKey = utils.bufferToKey(cid.buffer) | |||
|
|
|||
| parallel([ | |||
There was a problem hiding this comment.
what do you think on removing this async/parallel and using Promise.all with promisify for dht._betterPeersToQuery(msg, peer, cb)? We are converting to promises to callbacks here, and it would ease in the future to just remove the promisify from the last task
There was a problem hiding this comment.
Sure, I can migrate the internals of this. I was originally trying to avoid touching too much other than the datastore, but I can go ahead and refactor this.
There was a problem hiding this comment.
I created a new getProvidersAsync method that uses all the existing async methods, so no promisify is needed. getProviders now calls that with promise-to-callback support, so when we refactor internally we can just do a full swap out of those.
BREAKING CHANGE: This change requires datastores that comply with [email protected] or later.
This refactors internal usage of
datastoreto use the async api. I also bumpedaegirand fixed linting. Many of the rules forrequire-asyncare ignored at the moment, they should be removed once the full conversion is done.Note: the libp2p-record update is the last dependency needed to convert to full async/await.