fix: providers leaking resources on dht construction (#194)

* fix: providers leaking resources on dht construction

* chore: remove intervals validation on start and stop

Author: vasco-santos

package.json

@@ -77,7 +77,7 @@
     "delay": "^4.3.0",
     "dirty-chai": "^2.0.1",
     "it-pair": "^1.0.0",
-    "libp2p": "libp2p/js-libp2p#0.28.x",
+    "libp2p": "^0.28.0-rc.0",
     "lodash": "^4.17.11",
     "lodash.random": "^3.2.0",
     "lodash.range": "^3.2.0",

src/index.js

@@ -185,6 +185,7 @@ class KadDHT extends EventEmitter {
    */
   async start () {
     this._running = true
+    this.providers.start()
     this._queryManager.start()
     await this.network.start()
 

src/providers.js

@@ -58,16 +58,24 @@ class Providers {
     this.syncQueue = new Queue({ concurrency: 1 })
   }
 
+  /**
+   * Start the provider cleanup service
+   * @returns {void}
+   */
+  start () {
+    this._cleaner = setInterval(
+      () => this._cleanup(),
+      this.cleanupInterval
+    )
+  }
+
   /**
    * Release any resources.
-   *
    * @returns {void}
    */
   stop () {
-    if (this._cleaner) {
-      clearInterval(this._cleaner)
-      this._cleaner = null
-    }
+    clearInterval(this._cleaner)
+    this._cleaner = null
   }
 
   /**
@@ -155,23 +163,6 @@ class Providers {
     return provs
   }
 
-  get cleanupInterval () {
-    return this._cleanupInterval
-  }
-
-  set cleanupInterval (val) {
-    this._cleanupInterval = val
-
-    if (this._cleaner) {
-      clearInterval(this._cleaner)
-    }
-
-    this._cleaner = setInterval(
-      () => this._cleanup(),
-      this.cleanupInterval
-    )
-  }
-
   /**
    * Add a new provider for the given CID.
    *

test/providers.spec.js

@@ -88,6 +88,8 @@ describe('Providers', () => {
     providers.cleanupInterval = 100
     providers.provideValidity = 200
 
+    providers.start()
+
     const cid = new CID('QmdfTbBqBPQ7VNxZEYEj14VmRuZBkqFbiwReogJgS1zR1n')
     await Promise.all([
       providers.addProvider(cid, peerIds[0]),
@@ -104,6 +106,7 @@ describe('Providers', () => {
 
     const provsAfter = await providers.getProviders(cid)
     expect(provsAfter).to.have.length(0)
+    providers.stop()
   })
 
   // slooow so only run when you need to