Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency opencv-python #78

Closed
aentwist opened this issue Sep 7, 2024 · 5 comments · Fixed by #79
Closed

Remove dependency opencv-python #78

aentwist opened this issue Sep 7, 2024 · 5 comments · Fixed by #79

Comments

@aentwist
Copy link
Contributor

aentwist commented Sep 7, 2024

OpenCV is no longer used and should be removed. See #65

@aentwist aentwist changed the title opencv-python-headless Remove dependency opencv-python Sep 7, 2024
@aentwist
Copy link
Contributor Author

aentwist commented Sep 7, 2024

OpenCV depends on numpy, which we are using without having it declared as a dependency. So removing OpenCV breaks the code for that reason. We do use numpy (at least to_ndarray method), so I'll specify it.

@aentwist
Copy link
Contributor Author

aentwist commented Sep 7, 2024

Ok numpy 2 has at minimum python >=3.9, if not currently python >=3.10.

Should I stay with numpy 1 and keep our version of python

python = ">=3.8.1,<3.13"

or use numpy 2 and increase our version of python to 3.9 or 3.10?

@aentwist
Copy link
Contributor Author

aentwist commented Sep 7, 2024

The final version of numpy with python 3.8 support is 1.24

@aentwist
Copy link
Contributor Author

aentwist commented Sep 7, 2024

That is failing and all the sudden we are in dependency hell

Note: This error originates from the build backend, and is likely not a problem with poetry but with numpy (1.24.4) not supporting PEP 517 builds. You can verify this by running 'pip wheel --use-pep517 "numpy (==1.24.4)"'.

So I'm going to try going the other way with an increase to the minimum python version. Upon investigation, this is highly reasonable, as python 3.8 is end of life in like a month and 3.9 only has 1 more year until end of life. Let's go for numpy 2. https://devguide.python.org/versions/

@aentwist
Copy link
Contributor Author

aentwist commented Sep 7, 2024

I don't really understand how poetry works, I'm trying so hard 😵‍💫

This was referenced Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant