-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency opencv-python #78
Comments
OpenCV depends on numpy, which we are using without having it declared as a dependency. So removing OpenCV breaks the code for that reason. We do use numpy (at least |
Ok numpy 2 has at minimum python >=3.9, if not currently python >=3.10. Should I stay with numpy 1 and keep our version of python py-scrcpy-client/pyproject.toml Line 19 in 1488792
or use numpy 2 and increase our version of python to 3.9 or 3.10? |
The final version of numpy with python 3.8 support is 1.24 |
That is failing and all the sudden we are in dependency hell
So I'm going to try going the other way with an increase to the minimum python version. Upon investigation, this is highly reasonable, as python 3.8 is end of life in like a month and 3.9 only has 1 more year until end of life. Let's go for numpy 2. https://devguide.python.org/versions/ |
I don't really understand how poetry works, I'm trying so hard 😵💫 |
OpenCV is no longer used and should be removed. See #65
The text was updated successfully, but these errors were encountered: