Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pageVisibility state and monitoring code into the browserInfo utilities module #13143

Open
Tracked by #11722
rtibbles opened this issue Mar 4, 2025 · 0 comments

Comments

@rtibbles
Copy link
Member

rtibbles commented Mar 4, 2025

Currently our page visibliity state tracking code is part of our core vuex state: https://github.com/search?q=repo%3Alearningequality%2Fkolibri%20pageVisibility&type=code

This should be migrated to the browserInfo utilities module: https://github.com/learningequality/kolibri/blob/develop/packages/kolibri/utils/browserInfo.js

Instead of vuex state, we should create a VueJS ref to track the state in a reactive way, and export it from the module.

Any existing references to the pageVisibility state should be updated to reference this new export from the module.

Ideally, these would be done by returning the value from the setup function of any components using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant