Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testgrid/Configurator needs unit tests #13638

Closed
2 tasks done
chases2 opened this issue Jul 27, 2019 · 1 comment · Fixed by #13768
Closed
2 tasks done

Testgrid/Configurator needs unit tests #13638

chases2 opened this issue Jul 27, 2019 · 1 comment · Fixed by #13768
Assignees
@chases2
Labels
area/testgrid kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone
v1.16

Comments

@chases2
Copy link
Contributor

chases2 commented Jul 27, 2019 •
edited
Loading

What should be cleaned up or changed:
While the yaml2proto library that Configurator uses has tests, neither the prow portion nor the main file itself have unit or integration tests.

Testing would be a worthwhile investment into this component, which is becoming more complex and also more important for TestGrid's health.

Provide any links for context:
Configurator

  • Test prow.go
  • Test main.go

/area testgrid
/sig testing
/assign
@chases2 chases2 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 27, 2019
@k8s-ci-robot k8s-ci-robot added area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 27, 2019
@chases2 chases2 changed the title Testgrid/Configurator has no unit tests Testgrid/Configurator needs unit tests Jul 27, 2019
@chases2 chases2 mentioned this issue Jul 30, 2019
Merged
@spiffxp
Copy link
Member

spiffxp commented Jul 31, 2019

/milestone v1.16
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 31, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 31, 2019
This was referenced Aug 1, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chases2 chases2

Labels
area/testgrid kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
v1.16
Development

Successfully merging a pull request may close this issue.

Creation of Testgrid Configurator Test chases2/test-infra
3 participants
@spiffxp @chases2 @k8s-ci-robot