Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests that cover the pkg/apply package #2452

Open
astefanutti opened this issue Feb 26, 2025 · 6 comments · May be fixed by #2479
Open

Add unit tests that cover the pkg/apply package #2452

astefanutti opened this issue Feb 26, 2025 · 6 comments · May be fixed by #2479
Assignees
@akagami-harsh @Harshal292004
Labels
area/testing good first issue help wanted

Comments

@astefanutti
Copy link
Contributor

Following #2431 that introduced the pkg/apply support package, proper unit tests should be added as discussed in #2431 (review).
@astefanutti astefanutti mentioned this issue Feb 26, 2025
Merged
1 task
@andreyvelich
Copy link
Member

/good-first-issue
/area testing

@google-oss-prow Google OSS Prow
Copy link

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/area testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akagami-harsh
Copy link

/assign

@Harshal292004
Copy link

/assign

@akagami-harsh
Copy link

hey @Harshal292004 do you also want to work on this, i am almost done to make a pr

@Harshal292004
Copy link

@akagami-harsh if you are done then continue else I can work with you

@akagami-harsh akagami-harsh linked a pull request Mar 6, 2025 that will close this issue
Open
1 task
@tenzen-y tenzen-y mentioned this issue Mar 10, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akagami-harsh akagami-harsh

@Harshal292004 Harshal292004

Labels
area/testing good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Add unit tests for pkg/apply akagami-harsh/training-operator
4 participants
@astefanutti @andreyvelich @akagami-harsh @Harshal292004