fix(query): ListBundles returns all bundles even without dependencies

ListBundles query uses INNER JOIN which only intersection meaning it only
returns bundles with dependencies. Switching to LEFT OUTER JOIN to return
all bundles with or without dependencies.

Signed-off-by: Vu Dinh <[email protected]>

Author: dinhxuanvu

pkg/registry/populator.go

@@ -351,7 +351,6 @@ func parseDependenciesFile(path string, depFile *DependenciesFile) error {
 	for _, v := range deps.RawMessage {
 		// convert map to json
 		jsonStr, _ := json.Marshal(v)
-		fmt.Println(string(jsonStr))
 
 		// Check dependency type
 		dep := Dependency{}

pkg/registry/populator_test.go

@@ -449,6 +449,11 @@ func TestListBundles(t *testing.T) {
 	store, err := createAndPopulateDB(db)
 	require.NoError(t, err)
 
+	var count int
+	row := db.QueryRow("SELECT COUNT(*) FROM operatorbundle")
+	err = row.Scan(&count)
+	require.NoError(t, err)
+
 	expectedDependencies := []*api.Dependency{
 		{
 			Type:  "olm.package",
@@ -468,9 +473,13 @@ func TestListBundles(t *testing.T) {
 	bundles, err := store.ListBundles(context.TODO())
 	require.NoError(t, err)
 	for _, b := range bundles {
-		dep := b.Dependencies
-		dependencies = append(dependencies, dep...)
+		for _, d := range b.Dependencies {
+			if d.GetType() != "" {
+				dependencies = append(dependencies, d)
+			}
+		}
 	}
+	require.Equal(t, count, len(bundles))
 	require.ElementsMatch(t, expectedDependencies, dependencies)
 }
 

pkg/sqlite/query.go

@@ -788,7 +788,7 @@ func (s *SQLQuerier) ListBundles(ctx context.Context) (bundles []*api.Bundle, er
 	dependencies.type, dependencies.value
 	FROM channel_entry
 	INNER JOIN operatorbundle ON operatorbundle.name = channel_entry.operatorbundle_name
-	INNER JOIN dependencies ON dependencies.operatorbundle_name = channel_entry.operatorbundle_name
+	LEFT OUTER JOIN dependencies ON dependencies.operatorbundle_name = channel_entry.operatorbundle_name
 	INNER JOIN package ON package.name = channel_entry.package_name`
 
 	rows, err := s.db.QueryContext(ctx, query)
@@ -820,6 +820,9 @@ func (s *SQLQuerier) ListBundles(ctx context.Context) (bundles []*api.Bundle, er
 		if ok {
 			// Create new dependency object
 			dep := &api.Dependency{}
+			if !depType.Valid || !depValue.Valid {
+				continue
+			}
 			dep.Type = depType.String
 			dep.Value = depValue.String