Skip to content

Commit 11a9ab1

Browse files
authoredJul 16, 2024
[OpenMP] Fix comparison to True/False in openmp/**.py (#94041)
from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations): > Comparisons to singletons like None should always be done with is or is not, never the equality operators. Co-authored-by: Eisuke Kawashima <[email protected]>
1 parent 16dd75b commit 11a9ab1

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed
 

‎openmp/libompd/gdb-plugin/ompd/ompd.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def invoke(self, arg, from_tty):
5050
"No ompd_dll_locations symbol in execution, make sure to have an OMPD enabled OpenMP runtime"
5151
)
5252

53-
while gdb.parse_and_eval("(char**)ompd_dll_locations") == False:
53+
while not gdb.parse_and_eval("(char**)ompd_dll_locations"):
5454
gdb.execute("tbreak ompd_dll_locations_valid")
5555
gdb.execute("continue")
5656

‎openmp/tools/archer/tests/lit.cfg

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ if config.operating_system == 'Darwin':
8383
if 'Linux' in config.operating_system:
8484
config.available_features.add("linux")
8585

86-
if config.has_tsan == True:
86+
if config.has_tsan:
8787
config.available_features.add("tsan")
8888

8989
# to run with icc INTEL_LICENSE_FILE must be set

0 commit comments

Comments
 (0)
Please sign in to comment.