Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: GP Packages not properly specified #746

Open
2 tasks done
jbrande opened this issue Feb 11, 2025 · 0 comments
Open
2 tasks done

[Bug]: GP Packages not properly specified #746

jbrande opened this issue Feb 11, 2025 · 0 comments
Assignees
Labels
bug Something isn't working LC Fit

Comments

@jbrande
Copy link
Collaborator

jbrande commented Feb 11, 2025

FAQ check

  • Yes, I checked the FAQ and my question has not been addressed.

Instrument

Light curve fitting (Stages 4-6)

What happened?

It looks like the GPModel "gp_code_name" parameter isn't properly specified in s5_fit.py (line 919, gp_code instead of gp_code_name), so the GP package always gets defaulted to "celerite", rather than the actual specified package in the S5 ECF (e.g. "george").

Renaming the parameter in s5_fit.py to gp_code_name doesn't appear to break celerite, but I haven't tested george yet.

Error traceback output

No response

What operating system are you using?

No response

What version of Python are you running?

No response

What Python packages do you have installed?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working LC Fit
Projects
None yet
Development

No branches or pull requests

4 participants