CheckBoxMenuImplementation.mark_item_as_checked() is a misnommer

[lenormf]

Describe the bug
CheckBoxMenuImplementation.mark_item_as_checked() toggles the checked status of a given item.

To Reproduce
Steps to reproduce the behaviour:

1. Call mark_item_as_checked() twice, the item will still be unchecked

Expected behavior

I implemented the following methods on my overloaded widget, I think the naming makes more sense:

    def check_item(self, item):
        self._selected_item_dict[item] = True

    def uncheck_item(self, item):
        self._selected_item_dict[item] = False

    def toggle_item(self, item):
        self._selected_item_dict[item] = not self._selected_item_dict[item]

[jwlodek]

This issue has been resolved on the v0.1.4 branch, and is awaiting merging. The following functions are now available:

    def toggle_item_checked(self, item: Any):
        """Function that marks an item as selected

        Parameters
        ----------
        item : object
            Toggle item checked state
        """

        self._selected_item_dict[item] = not self._selected_item_dict[item]


    def mark_item_as_checked(self, item: Any) -> None:
        """Function that marks an item as selected

        Parameters
        ----------
        item : object
            Toggle item checked state
        """

        self._selected_item_dict[item] = True


    def mark_item_as_not_checked(self, item) -> None:
        """Function that marks an item as selected

        Parameters
        ----------
        item : object
            Item to uncheck
        """

        self._selected_item_dict[item] = False