Skip to content

Commit b48425b

Browse files
Improve lighting (#158)
* Improve lighting * Update Playwright Snapshots --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 parent cffb466 commit b48425b

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/jupytercad-extension/src/mainview.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -236,9 +236,9 @@ export class MainView extends React.Component<IProps, IStates> {
236236

237237
this._scene = new THREE.Scene();
238238

239-
this._scene.add(new THREE.AmbientLight(0xffffff, 0.8)); // soft white light
239+
this._scene.add(new THREE.AmbientLight(0xffffff, 0.5)); // soft white light
240240

241-
const light = new THREE.SpotLight(0xffffff, 0.2);
241+
const light = new THREE.PointLight(0xffffff, 1);
242242
light.castShadow = true;
243243
light.shadow.radius = 32;
244244
light.shadow.mapSize.width = 128;
@@ -601,7 +601,7 @@ export class MainView extends React.Component<IProps, IStates> {
601601
side: THREE.DoubleSide,
602602
wireframe: false,
603603
flatShading: false,
604-
shininess: 40
604+
shininess: 0
605605
});
606606

607607
const geometry = new THREE.BufferGeometry();
Loading

0 commit comments

Comments
 (0)