Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Mixing "text" and "notext" buttons in controlgroup #2484

Closed
@waylan

Description

@waylan

Given the following markup I expected the buttons to all be sized with the same proportions:

<div data-role="controlgroup" data-type="horizontal">
    <a id="back" data-role="button" data-icon="arrow-l" data-iconpos="notext"</a>
    <a id="text" data-role="button">Some text</a>
    <a id="forward" data-role="button" data-icon="arrow-r" data-iconpos="notext"></a>
</div>

Instead, the "notext" buttons are only about two-thirds the height of the "text" button - which looks ridiculous to say the least.

As a work-around I was able to do this:

<div data-role="controlgroup" data-type="horizontal">
    <a id="back" data-role="button" data-icon="arrow-l">&nbsp;</a>
    <a id="text" data-role="button">Some text</a>
    <a id="forward" data-role="button" data-icon="arrow-r" data-iconpos="right">&nbsp;</a>
</div>

But it feels hacky and leaves extra spaces in what should be "notext" buttons. In fact, if the "notext" buttons are not on the ends, there is no way to make this work with proper spacing (the icon would need to be between 2 non-braking spaces - uhg).

Having done some searching, this may or may-not be related to issue #1998.

Activity

toddparker

toddparker commented on Sep 21, 2011

@toddparker
Contributor

I see. We had conceived of the notext version as a small, round icon button like you see on a splitview, not as a large button but I can see a place for both types. We'll consider adding this as a new type post 1.0. Can you add this request to the feature request wiki page, then close this issue (we'll re-open when we add this).

_t

waylan

waylan commented on Sep 22, 2011

@waylan
Author

Added to Feature Requests. Thanks.

toddparker

toddparker commented on Sep 22, 2011

@toddparker
Contributor

Excellent, thanks!

jaspermdegroot

jaspermdegroot commented on Jul 18, 2012

@jaspermdegroot
Contributor

@waylan - This change landed in master (latest code) and will be part of 1.2.. I will remove the request from the wiki page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @waylan@toddparker@jaspermdegroot

        Issue actions

          Mixing "text" and "notext" buttons in controlgroup · Issue #2484 · jquery-archive/jquery-mobile