Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jootyuan/ripple-lib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: develop
Choose a base ref
...
head repository: XRPLF/xrpl.js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Able to merge. These branches can be automatically merged.

Commits on Nov 14, 2014

  1. [DOC] add doc that accountRequest throws

    if a marker is provided, but no ledger_index or ledger_hash
    geertweening committed Nov 14, 2014
    Copy the full SHA
    d3d85a3 View commit details
  2. Copy the full SHA
    fc426d5 View commit details
  3. Copy the full SHA
    b8766e2 View commit details
  4. Copy the full SHA
    cffffd9 View commit details

Commits on Nov 17, 2014

  1. Copy the full SHA
    ced07e1 View commit details
  2. Merge pull request XRPLF#209 from ximinez/ledger_accept

    Request ledger_accept returns the Request, not Remote
    wltsmrz committed Nov 17, 2014
    Copy the full SHA
    bc5dcc3 View commit details

Commits on Nov 18, 2014

  1. Copy the full SHA
    d6b1728 View commit details
  2. Merge pull request XRPLF#210 from geertweening/fix/max_fee

    [TASK] change default `max_fee` for Remote to 1 XRP
    wltsmrz committed Nov 18, 2014
    Copy the full SHA
    cc229e8 View commit details
  3. Copy the full SHA
    baed1aa View commit details
  4. Copy the full SHA
    d43fa03 View commit details
  5. Copy the full SHA
    06acb5f View commit details

Commits on Nov 19, 2014

  1. Fix link in README

    jks-liu committed Nov 19, 2014
    Copy the full SHA
    520660e View commit details
  2. Merge pull request XRPLF#211 from jks-liu/fix-link

    Fix link in README
    wltsmrz committed Nov 19, 2014
    Copy the full SHA
    672171f View commit details
  3. Copy the full SHA
    905f908 View commit details
  4. Copy the full SHA
    38e288f View commit details
  5. Copy the full SHA
    28451df View commit details
  6. Copy the full SHA
    bb79cf2 View commit details

Commits on Nov 20, 2014

  1. Copy the full SHA
    74cacd5 View commit details

Commits on Nov 26, 2014

  1. Copy the full SHA
    0d7fc0a View commit details
  2. Merge pull request XRPLF#214 from ripple/fix-fractional-drops

    Fix fractional drops in funded taker_pays setter
    geertweening committed Nov 26, 2014
    Copy the full SHA
    ccf218c View commit details
  3. Copy the full SHA
    e371cc2 View commit details

Commits on Nov 27, 2014

  1. Merge pull request XRPLF#215 from ripple/fix-precision-rounding

    Fix to_human precision rounding
    wltsmrz committed Nov 27, 2014
    Copy the full SHA
    c792c47 View commit details

Commits on Nov 29, 2014

  1. Copy the full SHA
    86ed24b View commit details

Commits on Nov 30, 2014

  1. Merge pull request XRPLF#217 from ripple/orderbook-cleanup

    Cleanup, normalize offers from book_offers and transaction stream
    geertweening committed Nov 30, 2014
    Copy the full SHA
    3a6c5e4 View commit details

Commits on Dec 1, 2014

  1. [FEATURE] improve memo support

    - add MemoFormat property for memo
    - MemoFormat and MemoType must be valid ASCII
    - Memo content is converted on the serialization level
    - add parsed_* version of Memo content if the parser understand the format
    - support `text` and `json` MemoFormat
    geertweening committed Dec 1, 2014
    Copy the full SHA
    89adcf4 View commit details

Commits on Dec 2, 2014

  1. [DOC] update generate wallet example

    to take advantage of randomness collected from a rippled
    geertweening committed Dec 2, 2014
    Copy the full SHA
    8e315a9 View commit details
  2. Merge pull request XRPLF#213 from geertweening/feature/memo_format_type

    [FEATURE] improve memo support
    wltsmrz committed Dec 2, 2014
    Copy the full SHA
    95a2cc1 View commit details

Commits on Dec 4, 2014

  1. Copy the full SHA
    28cc0f9 View commit details
  2. Copy the full SHA
    b4cabad View commit details
  3. Revert "[FEATURE] improve memo support"

    This reverts commit 89adcf4.
    geertweening committed Dec 4, 2014
    Copy the full SHA
    4bba55d View commit details
  4. Copy the full SHA
    84abb59 View commit details

Commits on Dec 5, 2014

  1. Copy the full SHA
    9cc6ad0 View commit details
  2. Copy the full SHA
    12e4287 View commit details

Commits on Dec 8, 2014

  1. [TASK] update sjcl

    - native support for k256
    - improved entropy by taking advantage of platform crypto
    
    - remove unnecessary sjcl overrides from sjcl-secp256k1.js
    - updated ripple-lib curve instantiations to use k256
    - add curve override so c256 points to k256
    
    bitwiseshiftleft/sjcl@16dde36
    geertweening committed Dec 8, 2014
    Copy the full SHA
    3204998 View commit details
  2. Merge pull request XRPLF#220 from geertweening/update_sjcl

    [TASK] update sjcl
    geertweening committed Dec 8, 2014
    Copy the full SHA
    634e811 View commit details

Commits on Dec 10, 2014

  1. Cleanup

    - Deprecate 'save' event
    - Add TransactionQueue.getMinLedger(), use this as ledger_index_min
      in account_tx request on reconnect
    - tx.sign() no longer accepts a callback
    - Add various setters and jsdoc to transaction.js
    - Normalize setters, e.g. sourceTag() and destinationTag()
    - Minor optimization in call to tx.hash() in TransactionManager prior
      to submit; allow `serialized` argument to tx.hash() such that the
      transaction is not serialized twice
    wltsmrz authored and geertweening committed Dec 10, 2014
    Copy the full SHA
    c5bd423 View commit details
  2. Copy the full SHA
    d5ef477 View commit details
  3. Copy the full SHA
    73a3cce View commit details
  4. Rework tef and tel-class transaction error handling

    Do not finalize tef or tel-class errors until LastLedgerSequence is
    exceeded. Transactions that fail in this way will now be aborted
    with a tej-class error. Errors like tefALREADY and tefMAX_LEDGER
    should now be opaque to the user and have no consequence in
    determining a final state.
    wltsmrz authored and geertweening committed Dec 10, 2014
    Copy the full SHA
    1a892d5 View commit details
  5. Merge pull request XRPLF#221 from ripple/transaction-updates

    Transaction updates
    geertweening committed Dec 10, 2014
    Copy the full SHA
    0835de9 View commit details
  6. Copy the full SHA
    9b22f27 View commit details
  7. Merge pull request XRPLF#222 from boxbag/transaction-set-fee

    [FEATURE] allow per transaction fees to be set
    geertweening committed Dec 10, 2014
    Copy the full SHA
    666e434 View commit details
  8. [FEATURE] improve memo support

    - add MemoFormat property for memo
    - MemoFormat and MemoType must be valid ASCII
    - Memo content is converted on the serialization level
    - add parsed_* version of Memo content if the parser understand the format
    - support `text` and `json` MemoFormat
    
    [FIX] double serialization overriding Memo contents
    
    The copy made in from_json wasn't a deep copy
    geertweening committed Dec 10, 2014
    Copy the full SHA
    1704ac4 View commit details
  9. Merge pull request XRPLF#223 from geertweening/feature/memo_format_type

    [FEATURE] improve memo support
    geertweening committed Dec 10, 2014
    Copy the full SHA
    fcc2377 View commit details
  10. Copy the full SHA
    2222adf View commit details
  11. [DOC] Update release notes

    wltsmrz committed Dec 10, 2014
    Copy the full SHA
    6ec8124 View commit details
  12. Copy the full SHA
    e32694d View commit details
  13. Copy the full SHA
    d15d14e View commit details

Commits on Dec 11, 2014

  1. Copy the full SHA
    3c21994 View commit details
  2. Copy the full SHA
    1eaad61 View commit details
Showing 1,420 changed files with 110,439 additions and 68,882 deletions.
56 changes: 56 additions & 0 deletions .ci-config/getNewAmendments.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
const xrpl = require("xrpl");
const fs = require("fs");
const path = require("path");

const filePath = path.resolve(__dirname, "./rippled.cfg");
const existingConfig = fs.readFileSync(filePath, "utf-8");

const networkToEmulate = "wss://s.devnet.rippletest.net:51233/";

const amendmentsToIgnore = [
"86E83A7D2ECE3AD5FA87AB2195AE015C950469ABF0B72EAACED318F74886AE90", // CryptoConditionsSuite is obsolete
];

async function main() {
const client = new xrpl.Client(networkToEmulate);
await client.connect();

// Looks up what amendments have been enabled via their hash
const request = {
command: "ledger_entry",
index: "7DB0788C020F02780A673DC74757F23823FA3014C1866E72CC4CD8B226CD6EF4",
ledger_index: "validated",
};
const response = await client.request(request);

const amendments = response.result.node.Amendments;

const newAmendments = [];
amendments.forEach((amendment) => {
if (
!existingConfig.includes(amendment) &&
!amendmentsToIgnore.includes(amendment)
) {
newAmendments.push(amendment);
}
});

if (newAmendments.length > 0) {
console.log(
"New Amendment Hashes - Look up their names on https://xrpl.org/known-amendments.html"
);
newAmendments.forEach((amendment) => {
console.log(amendment);
});
} else {
console.log(
`No new amendments to add!
Looking at network: ${networkToEmulate}.
Path to config: ${filePath}`
);
}

await client.disconnect();
}

main().catch((error) => console.log(error));
186 changes: 186 additions & 0 deletions .ci-config/rippled.cfg
Original file line number Diff line number Diff line change
@@ -0,0 +1,186 @@
[server]
port_rpc_admin_local
port_ws_public
port_ws_admin_local

# port_peer
# port_ws_admin_local
# ssl_key = /etc/ssl/private/server.key
# ssl_cert = /etc/ssl/certs/server.crt

# IPs must be 0.0.0.0 instead of 127.0.0.1 to be accessed outside the docker container

[port_rpc_admin_local]
port = 5005
ip = 0.0.0.0
admin = 0.0.0.0
protocol = http

[port_ws_public]
port = 80
ip = 0.0.0.0
protocol = ws

# [port_peer]
# port = 51235
# ip = 0.0.0.0
# protocol = peer

[port_ws_admin_local]
port = 6006
ip = 0.0.0.0
admin = 0.0.0.0
protocol = ws

[node_size]
small

# tiny
# small
# medium
# large
# huge

[node_db]
type=NuDB
path=/var/lib/rippled/db/nudb
advisory_delete=0

# How many ledgers do we want to keep (history)?
# Integer value that defines the number of ledgers
# between online deletion events
online_delete=256

[ledger_history]
# How many ledgers do we want to keep (history)?
# Integer value (ledger count)
# or (if you have lots of TB SSD storage): 'full'
256

[database_path]
/var/lib/rippled/db

[debug_logfile]
/var/log/rippled/debug.log

[network_id]
0


[rpc_startup]
{ "command": "log_level", "severity": "info" }

# severity (order: lots of information .. only errors)
# debug
# info
# warn
# error
# fatal

[ssl_verify]
1

# The [features] stanza does not currently work for standalone mode: https://github.com/XRPLF/xrpl-dev-portal/issues/1762#issuecomment-1441252450


# In order to enable an amendment which by default would vote "No", you must include its amendment id and name here.
# To add amendments specifically from the latest releases of rippled:
# 1. Go to https://xrpl.org/known-amendments.html
# 2. Find the first amendment in the latest releases of rippled which are not already in the list below
# 3. Click on each amendment to get their Amendment ID and name to add to this list manually.
# You will likely update the list with all amendments from a new release of rippled all at once.

# To get the list of amendments on a network (e.g. devnet) follow the steps in xrpl.js's CONTRIBUTING.md for "Updating the Docker container".
# https://github.com/XRPLF/xrpl.js/blob/main/CONTRIBUTING.md
# (Running the script `getNewAmendments.js` should help you identify any new amendments that should be added.)
#
# Note: The version of rippled you use this config with must have an implementation for the amendments you attempt to enable or it will crash.
# If you need the version of rippled to be more up to date, you may need to make a comment on this repo: https://github.com/WietseWind/docker-rippled

[features]
# Devnet amendments as of June 28th, 2023
NegativeUNL
fixRemoveNFTokenAutoTrustLine
NonFungibleTokensV1
CheckCashMakesTrustLine
fixRmSmallIncreasedQOffers
fixSTAmountCanonicalize
FlowSortStrands
TicketBatch
fix1201
fixQualityUpperBound
FlowCross
EnforceInvariants
fix1523
HardenedValidations
DepositPreauth
MultiSignReserve
fix1623
FeeEscalation
PayChan
fix1513
RequireFullyCanonicalSig
fix1543
TickSize
fix1781
fixCheckThreading
fix1515
CryptoConditions
fix1528
fixPayChanRecipientOwnerDir
SortedDirectories
fix1578
fix1571
fixAmendmentMajorityCalc
fixTakerDryOfferRemoval
fixMasterKeyAsRegularKey
Flow
Escrow
TrustSetAuth
DeletableAccounts
DepositAuth
fix1368
fix1512
fix1373
MultiSign
Checks
NonFungibleTokensV1_1
# 1.10.0 Amendments
DisallowIncoming
fixNonFungibleTokensV1_2
fixTrustLinesToSelf
fixUniversalNumber
ImmediateOfferKilled
XRPFees
# 1.11.0 Amendments
ExpandedSignerList
# 1.12.0 Amendments
AMM
Clawback
fixReducedOffersV1
fixNFTokenRemint
# 2.0.0 Amendments
XChainBridge
DID
# 2.2.0-b3 Amendments
fixNFTokenReserve
fixInnerObjTemplate
fixAMMOverflowOffer
PriceOracle
fixEmptyDID
fixXChainRewardRounding
fixPreviousTxnID
fixAMMv1_1
# 2.3.0 Amendments
AMMClawback
fixAMMv1_2
Credentials
NFTokenMintOffer
MPTokensV1
fixNFTokenPageLinks
fixInnerObjTemplate2
fixEnforceNFTokenTrustline
fixReducedOffersV2
DeepFreeze
DynamicNFT
PermissionedDomains
30 changes: 30 additions & 0 deletions .coderabbit.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
language: "en-US"
reviews:
# Set the profile for reviews. Assertive profile yields more feedback, that may be considered nitpicky.
profile: "chill"
# Approve the review once CodeRabbit's comments are resolved. Note: In GitLab, all discussions must be resolved.
request_changes_workflow: false
# Generate a high level summary of the changes in the PR/MR description.
high_level_summary: false
# Generate a poem in the walkthrough comment.
poem: true
# Post review details on each review. Additionally, post a review status when a review is skipped in certain cases.
review_status: true
# Generate walkthrough in a markdown collapsible section.
collapse_walkthrough: false
# Generate sequence diagrams in the walkthrough.
sequence_diagrams: false
# Abort the in-progress review if the pull request is closed or merged.
abort_on_close: true
auto_review:
# Automatic Review | Automatic code review
enabled: true
# Review draft PRs/MRs.
drafts: false
# Ignore reviewing if the title of the pull request contains any of these keywords (case-insensitive).
ignore_title_keywords:
- build(
chat:
# Enable the bot to reply automatically without requiring the user to tag it.
auto_reply: true
8 changes: 8 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
version: 2
updates:
- package-ecosystem: npm
directory: "/"
schedule:
interval: weekly
time: "15:00"
open-pull-requests-limit: 10
48 changes: 48 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
## High Level Overview of Change

<!--
Please include a summary/list of the changes.
If too broad, please consider splitting into multiple PRs.
If a relevant Asana task, please link it here.
-->

### Context of Change

<!--
Please include the context of a change.
If a bug fix, when was the bug introduced? What was the behavior?
If a new feature, why was this architecture chosen? What were the alternatives?
If a refactor, how is this better than the previous implementation?
If there is a design document for this feature, please link it here.
-->

### Type of Change

<!--
Please check relevant options, delete irrelevant ones.
-->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new feature included in this PR)
- [ ] Documentation Updates
- [ ] Release

### Did you update HISTORY.md?

- [ ] Yes
- [ ] No, this change does not impact library users

## Test Plan

<!--
Please describe the tests that you ran to verify your changes and provide instructions so that others can reproduce.
-->

<!--
## Future Tasks
For future tasks related to PR.
-->
65 changes: 65 additions & 0 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
# For most projects, this workflow file will not need changing; you simply need
# to commit it to your repository.
#
# You may wish to alter this file to override the set of languages analyzed,
# or to provide custom queries or build logic.
#
# ******** NOTE ********
# We have attempted to detect the languages in your repository. Please check
# the `language` matrix defined below to confirm you have the correct set of
# supported CodeQL languages.
#
name: "CodeQL"

on:
pull_request:
# The branches below must be a subset of the branches above
branches: [main]
schedule:
- cron: "44 5 * * 6"

jobs:
analyze:
name: Analyze
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
language: ["javascript"]
# CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ]
# Learn more:
# https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed

steps:
- name: Checkout repository
uses: actions/checkout@v4

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v3
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
# By default, queries listed here will override any specified in a config file.
# Prefix the list here with "+" to use these queries and those in the config file.
# queries: ./path/to/local/query, your-org/your-repo/queries@main

# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v3

# ℹ️ Command-line programs to run using the OS shell.
# 📚 https://git.io/JvXDl

# ✏️ If the Autobuild fails above, remove it and uncomment the following three lines
# and modify them (or add more) to build your code if your project
# uses a compiled language

#- run: |
# make bootstrap
# make release

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3
Loading