Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetty: JettyServer no longer takes a QueuedThreadPool #3590

Closed
jtlapp opened this issue Dec 1, 2024 · 1 comment
Closed

jetty: JettyServer no longer takes a QueuedThreadPool #3590

jtlapp opened this issue Dec 1, 2024 · 1 comment

Comments

@jtlapp
Copy link

jtlapp commented Dec 1, 2024

The documentation includes the following example:

  QueuedThreadPool worker = new QueuedThreadPool();
  worker.setReservedThreads(0);
  worker.setVirtualThreadsExecutor(Executors.newVirtualThreadPerTaskExecutor());

  install(new JettyServer(worker));

However, there is no JettyServer constructor taking a thread pool at present.

Are we supposed to be doing this a different way now?

@jknack
Copy link
Member

jknack commented Dec 3, 2024

yea, I removed when upgrade to 12.x find it far more complex to setup in 12.x... but I can probably added it back.

@jknack jknack added this to the 3.5.5 milestone Dec 8, 2024
@jknack jknack changed the title [docs] JettyServer no longer takes a QueuedThreadPool jetty: JettyServer no longer takes a QueuedThreadPool Dec 8, 2024
@jknack jknack closed this as completed in 2998385 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants