Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to generics [internal] #1764

Open
johnkerl opened this issue Mar 5, 2025 · 0 comments
Open

Switch to generics [internal] #1764

johnkerl opened this issue Mar 5, 2025 · 0 comments

Comments

@johnkerl
Copy link
Owner

johnkerl commented Mar 5, 2025

Miller was ported to Go before generics existed, but they've been part of the Go language for quite a while now.

Main items:

  • list.List -- awkward to genericize (namely Front, Back, Next) -- but it's better to simply use slices which are (and have always been) typed
  • Genericize Miller's lib.OrderedMap

Why:

  • Improved code legibility
  • Moving from linked lists to sliced may positively impact performance due to simpler memory allocation
  • Good development project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johnkerl