Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing license field in package metadata #78

Closed
remram44 opened this issue Sep 2, 2020 · 3 comments · Fixed by #79
Closed

Missing license field in package metadata #78

remram44 opened this issue Sep 2, 2020 · 3 comments · Fixed by #79

Comments

@remram44
Copy link

remram44 commented Sep 2, 2020

Hi,

It would be helpful if the license field could be populated, this helps automated tools. The SPDX identifier for the "new" BSD license is BSD-3-Clause, I assume it goes in pyproject.toml (I don't use flit, but that's where it goes with Poetry).

Thanks everyone for joblib, and sorry about the nitpick.

@jeremiedbb
Copy link
Contributor

Hi @remram44, according to flit's doc (here), it's preferred to specify the license through the classifiers field. We do have a trove classifier for the license. Have you found an issue with an automated tool in particular ?

@remram44
Copy link
Author

remram44 commented Sep 3, 2020

pip itself is one: pypa/pip#6677

Somehow the old docs for distutils used to recommend classifiers over the license field, even though that's been officially replaced by setuptools long ago. If tools like flit still say that I'm going to have to start there...

The Python sides seems to be dragging its feed too coming up with a clear recommendation (since PEP 459 has been withdrawn) so if you feel strongly about not adding this field I really can't point you to a doc that says you MUST do it. It's just that tools seem to rely on the license field (pip, and pip-licenses in default mode) and that the license field behaves better in the presence of multiple licenses (AND/OR operators).

@jeremiedbb
Copy link
Contributor

Thanks for the clarification and sorry for the delay. I guess it can't hurt to add it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants