Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorio yellow belt parrot #659

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Factorio yellow belt parrot #659

merged 2 commits into from
Oct 23, 2024

Conversation

cudy789
Copy link
Contributor

@cudy789 cudy789 commented Oct 22, 2024

A party parrot riding a Factorio yellow belt. Chainable!

@jmhobbs jmhobbs assigned jmhobbs and cudy789 and unassigned jmhobbs Oct 22, 2024
@jmhobbs
Copy link
Owner

jmhobbs commented Oct 22, 2024

I love it! Have a test failure there, because of the size/dimensions 🤔 I'm wondering if there should be a class of "non-standard dimensions" gifs or something. I know Slack is more lax in what they accept these days.

I'd also love it if you could make the white corners transparent if you have a moment!

:05:43 PM:   2 failing
5:05:43 PM:   1) parrots gifs
5:05:43 PM:        in SD should weigh less than 128KB:
5:05:43 PM:      AssertionError: beltparrot.gif is too big(146.546875 KB)
5:05:43 PM:       at /opt/build/repo/test/size.js:23:9
5:05:43 PM:       at Array.forEach (<anonymous>)
5:05:43 PM:       at Context.<anonymous> (test/size.js:21:12)
5:05:43 PM: 
5:05:43 PM:   2) parrots gifs
5:05:43 PM:        should never be wider or taller than 128px:
5:05:43 PM:      AssertionError: beltparrot.gif is wider than 128px
5:05:43 PM:       at /opt/build/repo/test/size.js:34:9
5:05:43 PM:       at Array.forEach (<anonymous>)
5:05:43 PM:       at Context.<anonymous> (test/size.js:31:12)

@cudy789
Copy link
Contributor Author

cudy789 commented Oct 22, 2024

Thanks! Been playing the new space age DLC :) I fixed the dimensions and size, the background is already transparent as well (no white corners).

@jmhobbs
Copy link
Owner

jmhobbs commented Oct 23, 2024

Excellent! Thank you so much!

@jmhobbs jmhobbs merged commit 1a49f72 into jmhobbs:main Oct 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants