Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Sneezy Parrot #533

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Adding Sneezy Parrot #533

merged 3 commits into from
Jan 19, 2021

Conversation

jacobrose
Copy link
Contributor

This poor parrot can't stop blowing their beak into a tissue. Is it
allergies? A cold? All we know is that we hope they feel better soon.

This poor parrot can't stop blowing their beak into a tissue. Is it
allergies? A cold? All we know is that we hope they feel better soon.
@jacobrose jacobrose mentioned this pull request Jan 8, 2021
@jmhobbs
Copy link
Owner

jmhobbs commented Jan 11, 2021

Looks great!

Just needs a few changes. Since it's a bigger gif, we would count it as HD quality. If you could move the gif into parrots/hd/ and then update the yaml to match,

- hd: hd/sneezyparrot.gif
  name: Sneezy Parrot

then the tests should pass.

Also, it looks like the gif was committed with the execute bit on, which will need to be changed.

AssertionError: sneezyparrot.gif has bad permissions, 0775

If you need me to do those things, I'm happy to handle it, let me know.

Thanks for contributing!

@jacobrose
Copy link
Contributor Author

Thank you, @jmhobbs!

I've updated per your instructions. After one last tweak, it looks like the build has succeeded 😅

Thanks again!

Jacob

@jmhobbs
Copy link
Owner

jmhobbs commented Jan 19, 2021

Excellent, thanks! ✅

@jmhobbs jmhobbs merged commit bf6a184 into jmhobbs:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants