Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Turn Down for Watch Parrot #517

Merged
merged 5 commits into from
Nov 9, 2020
Merged

Added Turn Down for Watch Parrot #517

merged 5 commits into from
Nov 9, 2020

Conversation

xMcLOVINx
Copy link

No description provided.

Copy link
Owner

@jmhobbs jmhobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gif is too large for the default folder, can you move it to parrots/hd/? Additionally you'll need to update the gif: turndownforwatchparrot.gif key in the YAML to hd: hd/turndownforwatchparrot.gif

Thanks!

@xMcLOVINx
Copy link
Author

How can I move this file?

@jmhobbs
Copy link
Owner

jmhobbs commented Nov 8, 2020

No worries, I can move it 👍

@jmhobbs
Copy link
Owner

jmhobbs commented Nov 8, 2020

Bah, now it's a size issue. I'll see what I can do. It needs to be < 128px in both height and width, and <128kb in size.

@xMcLOVINx
Copy link
Author

Ty ^^

@jmhobbs jmhobbs merged commit fcd26e6 into jmhobbs:master Nov 9, 2020
jmhobbs added a commit that referenced this pull request Nov 9, 2020
* Added turn down for watch parrot gif

* Update parrots.yaml

* Move turn down for watch to HD

* Decrease turndownforwatchparrot.gif to fit spec.

Co-authored-by: John Hobbs <[email protected]>
@xMcLOVINx
Copy link
Author

Can you add the "hacktoberfest-accepted" label, or approve my pull request to be used in hacktoberfest?

@jmhobbs
Copy link
Owner

jmhobbs commented Dec 15, 2020

Shouldn't be needed since the project has the tag, but I'll give it a shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants