Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix yaml unicode strings #475

Merged
merged 2 commits into from
May 15, 2020
Merged

fix yaml unicode strings #475

merged 2 commits into from
May 15, 2020

Conversation

HidingCherry
Copy link
Contributor

No description provided.

@jmhobbs
Copy link
Owner

jmhobbs commented May 15, 2020

Nice! My question is that it renders correctly in the page, but the JSON has extra quotes:

  {
    "gif": "pizzaparrot.gif",
    "name": "\"\\U0001F355 Parrot\""
  },
  {
    "gif": "hamburgerparrot.gif",
    "name": "\"\\U0001F354 Parrot\""
  },
  {
    "gif": "bananaparrot.gif",
    "name": "\"\\U0001F34C Parrot\""
  },

https://deploy-preview-475--cultofthepartyparrot.netlify.app/parrots.json

@HidingCherry
Copy link
Contributor Author

HidingCherry commented May 15, 2020

Then you maybe want to use this command:
npx -p js-yaml js-yaml parrots.yaml
Then this is fixed :)

edit: I temporarily created the json here:
https://github.com/Loader009/cultofthepartyparrot.com/blob/test/parrots.json#L104
But I used the command above manually instead of doing make build

@jmhobbs
Copy link
Owner

jmhobbs commented May 15, 2020

Hot damn! Thank you so much!

@jmhobbs jmhobbs merged commit 30d578d into jmhobbs:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants