-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add maracasparrot #410
add maracasparrot #410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great parrot! One fix to the JSON and we can merge it in. Thanks!
parrots.json
Outdated
@@ -684,4 +684,8 @@ | |||
"gif": "braveheartparrot.gif", | |||
"name": "Braveheart Parrot" | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! Needs a comma here 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, thanks!
🎉 |
parrots.json
Outdated
@@ -683,5 +683,9 @@ | |||
{ | |||
"gif": "braveheartparrot.gif", | |||
"name": "Braveheart Parrot" | |||
}, | |||
{ | |||
"gif": "hd/maracasparrot.gif", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops! I missed this on the first pass.
It should be "hd": "hd/maracasparrot.gif",
instead of "gif": ...
Sorry!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I was wondering why it was failing all checks lol,
cheers
Excellent, thank you! |
No description provided.