Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add maracasparrot #410

Merged
merged 5 commits into from
Oct 9, 2019
Merged

add maracasparrot #410

merged 5 commits into from
Oct 9, 2019

Conversation

kevinhhuynh
Copy link
Contributor

No description provided.

Copy link
Owner

@jmhobbs jmhobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great parrot! One fix to the JSON and we can merge it in. Thanks!

parrots.json Outdated
@@ -684,4 +684,8 @@
"gif": "braveheartparrot.gif",
"name": "Braveheart Parrot"
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Needs a comma here 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks!

@kevinhhuynh kevinhhuynh requested a review from jmhobbs October 9, 2019 17:05
@jmhobbs
Copy link
Owner

jmhobbs commented Oct 9, 2019

🎉

parrots.json Outdated
@@ -683,5 +683,9 @@
{
"gif": "braveheartparrot.gif",
"name": "Braveheart Parrot"
},
{
"gif": "hd/maracasparrot.gif",
Copy link
Owner

@jmhobbs jmhobbs Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! I missed this on the first pass.
It should be "hd": "hd/maracasparrot.gif", instead of "gif": ...
Sorry!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I was wondering why it was failing all checks lol,

cheers

@kevinhhuynh kevinhhuynh requested a review from jmhobbs October 9, 2019 17:26
@jmhobbs jmhobbs merged commit d1bf2e1 into jmhobbs:master Oct 9, 2019
@jmhobbs
Copy link
Owner

jmhobbs commented Oct 9, 2019

Excellent, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants