Various cleanups of the make script. #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds checks for `md5`/`md5sum` and `svgo` - Fall back to `md5sum` on systems which do not have `md5` - Removes use of `--lossy` from `gifsicle`, as it is not a parameter on the program - Removes use of `-warn` from `pngcrush`, as it is not a parameter on the program
jmhobbs
reviewed
Mar 13, 2019
| if ! [ -f "$CACHE_FILE" ]; then | ||
| case ${FILE##*.} in | ||
| "gif") | ||
| gifsicle --lossy --optimize=3 "$FILE" > "$CACHE_FILE" |
There was a problem hiding this comment.
So, I locally switched to the giflossy fork for that feature. Maybe we could feature detect on this?
| ;; | ||
| "jpg") | ||
| jpegtran -progressive -optimize -copy none -outfile "$CACHE_FILE" "$FILE" | ||
| ;; | ||
| "png") | ||
| pngcrush -reduce -s -warn "$FILE" "$CACHE_FILE" |
There was a problem hiding this comment.
For pngcrush I have 1.8.11, which has the -warn flag. This was added in 1.8.9 it appears, so may just be a versioning issue?
There was a problem hiding this comment.
It is a versioning thing...now 2.0 is out, so I'm upgraded (now).
There was a problem hiding this comment.
Is there a fork? I just checked homebrew and it's still 1.8.13, not seeing a 2.0 on the project page anywhere either.
|
Gonna go ahead and merge these. giflossy can be added back later if we want. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
md5/md5sumandsvgomd5sumon systems which do not havemd5--lossyfromgifsicle, as it is not a parameteron the program
-warnfrompngcrush, as it is not a parameter onthe program