Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this.fetch in store swallows errors #238

Closed
sporto opened this issue Mar 29, 2015 · 2 comments · Fixed by #241
Closed

this.fetch in store swallows errors #238

sporto opened this issue Mar 29, 2015 · 2 comments · Fixed by #241

Comments

@sporto
Copy link
Contributor

sporto commented Mar 29, 2015

In my store I had something like

    fetchLibraries(keyword) {
        return this.fetch({
            id: keyword,
            locally: function () {
                ...
            },
            remotely: function () {
                return librariesQuery.fetchLibraries(keyword);
            }
        });
    }

But in my Query I had:

  getLibraries(keyword) {
     ...

So getLibraries as opposed to fetchLibraries.

Browser shows no errors at all, the failed callback on createContainer gets called. But this is far from desired. Optimally only errors coming from actual fetch later on should be catched.

@sporto
Copy link
Contributor Author

sporto commented Mar 29, 2015

@jhollingworth
Copy link
Contributor

Completely agree with you. Thats a hangover from v0.8 where we attempted to handle errors for you. Will remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants