From 5dff8f686df8a17231d05c2beb9b25ba2ee4e2dc Mon Sep 17 00:00:00 2001 From: Quentin Monmert Date: Sat, 24 Jul 2021 20:24:34 +0200 Subject: [PATCH] [Angular] Clean code --- .../app/admin/health/modal/health-modal.component.ts.ejs | 6 ++---- .../src/main/webapp/app/layouts/main/main.component.ts.ejs | 4 ++-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/generators/client/templates/angular/src/main/webapp/app/admin/health/modal/health-modal.component.ts.ejs b/generators/client/templates/angular/src/main/webapp/app/admin/health/modal/health-modal.component.ts.ejs index d37a3bffa99c..589f3182ba03 100644 --- a/generators/client/templates/angular/src/main/webapp/app/admin/health/modal/health-modal.component.ts.ejs +++ b/generators/client/templates/angular/src/main/webapp/app/admin/health/modal/health-modal.component.ts.ejs @@ -36,16 +36,14 @@ export class HealthModalComponent { const val = value / 1073741824; if (val > 1) { return `${val.toFixed(2)} GB`; - } else { - return `${(value / 1048576).toFixed(2)} MB`; } + return `${(value / 1048576).toFixed(2)} MB`; } if (typeof value === 'object') { return JSON.stringify(value); - } else { - return String(value); } + return String(value); } dismiss(): void { diff --git a/generators/client/templates/angular/src/main/webapp/app/layouts/main/main.component.ts.ejs b/generators/client/templates/angular/src/main/webapp/app/layouts/main/main.component.ts.ejs index 5338725e714c..488dd303f1a5 100644 --- a/generators/client/templates/angular/src/main/webapp/app/layouts/main/main.component.ts.ejs +++ b/generators/client/templates/angular/src/main/webapp/app/layouts/main/main.component.ts.ejs @@ -79,9 +79,9 @@ export class MainComponent implements OnInit { } private getPageTitle(routeSnapshot: ActivatedRouteSnapshot): string { - let title: string = routeSnapshot.data['pageTitle'] ?? ''; + const title: string = routeSnapshot.data['pageTitle'] ?? ''; if (routeSnapshot.firstChild) { - title = this.getPageTitle(routeSnapshot.firstChild) || title; + return this.getPageTitle(routeSnapshot.firstChild) || title; } return title; }