Merge pull request #14288 from qmonmert/fix/sonar-code-smell

Sonar: fix code smells

Author: pascalgrimaud

generators/client/templates/angular/src/main/webapp/app/admin/configuration/configuration.component.ts.ejs

@@ -44,8 +44,10 @@ export class ConfigurationComponent implements OnInit {
   }
 
   filterAndSortBeans(): void {
+    const beansAscendingValue = this.beansAscending ? -1 : 1;
+    const beansAscendingValueReverse = this.beansAscending ? 1 : -1;
     this.beans = this.allBeans
       .filter(bean => !this.beansFilter || bean.prefix.toLowerCase().includes(this.beansFilter.toLowerCase()))
-      .sort((a, b) => (a.prefix < b.prefix ? (this.beansAscending ? -1 : 1) : this.beansAscending ? 1 : -1));
+      .sort((a, b) => (a.prefix < b.prefix ? beansAscendingValue : beansAscendingValueReverse));
   }
 }

generators/client/templates/angular/src/main/webapp/app/layouts/navbar/navbar.component.ts.ejs

@@ -43,7 +43,7 @@ export class NavbarComponent implements OnInit {
   languages = LANGUAGES;
   <%_ } _%>
   openAPIEnabled?: boolean;
-  version: string;
+  version = '';
 
   constructor(
     private loginService: LoginService,
@@ -55,7 +55,9 @@ export class NavbarComponent implements OnInit {
     private profileService: ProfileService,
     private router: Router
   ) {
-    this.version = VERSION ? (VERSION.toLowerCase().startsWith('v') ? VERSION : 'v' + VERSION) : '';
+    if (VERSION) {
+      this.version = VERSION.toLowerCase().startsWith('v') ? VERSION : 'v' + VERSION;
+    }
   }
 
   ngOnInit(): void {