Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 0b5c194

Browse files
mmistakesjesuswasrasta
authored andcommittedJul 8, 2020
Replace custom comment hardcoded HTML with include
Also add custom_scripts.html include for custom comment provider JavaScript that loads in the footer. Close mmistakes#2549
1 parent bdd8ddd commit 0b5c194

File tree

5 files changed

+8
-3
lines changed

5 files changed

+8
-3
lines changed
 

‎CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
### Enhancements
44

5+
- Replace `<section id="custom-comments"></section>` in `comments.html` include and add `custom_scripts.html` include for loading custom comment provider JavaScript in the footer. [#2549](https://github.com/mmistakes/minimal-mistakes/issues/2549)
56
- Move page date Liquid to include. [#2544](https://github.com/mmistakes/minimal-mistakes/pull/2544)
67
- Strip trailing whitespace in seo_description. [#2542](https://github.com/mmistakes/minimal-mistakes/pull/2542)
78
- Improve sticky sidebar's appearance with short content. [#2514](https://github.com/mmistakes/minimal-mistakes/pull/2514)
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
<!-- start custom comments scripts -->
2+
3+
<!-- end custom comments scripts -->

‎_includes/comments-providers/scripts.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@
1313
{% when "utterances" %}
1414
{% include /comments-providers/utterances.html %}
1515
{% when "custom" %}
16-
{% include /comments-providers/custom.html %}
16+
{% include /comments-providers/custom_scripts.html %}
1717
{% endcase %}
1818
{% endif %}

‎_includes/comments.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,6 @@ <h4 class="page__comments-title">{{ site.data.ui-text[site.locale].comments_labe
154154
<h4 class="page__comments-title">{{ comments_label }}</h4>
155155
<section id="utterances-comments"></section>
156156
{% when "custom" %}
157-
<section id="custom-comments"></section>
157+
{% include /comments-providers/custom.html %}
158158
{% endcase %}
159159
</div>

‎docs/_docs/18-history.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,15 @@ permalink: /docs/history/
55
excerpt: "Change log of enhancements and bug fixes made to the theme."
66
sidebar:
77
nav: docs
8-
last_modified_at: 2020-06-02T22:23:56-04:00
8+
last_modified_at: 2020-06-02T22:31:55-04:00
99
toc: false
1010
---
1111

1212
## Unreleased
1313

1414
### Enhancements
1515

16+
- Replace `<section id="custom-comments"></section>` in `comments.html` include and add `custom_scripts.html` include for loading custom comment provider JavaScript in the footer. [#2549](https://github.com/mmistakes/minimal-mistakes/issues/2549)
1617
- Move page date Liquid to include. [#2544](https://github.com/mmistakes/minimal-mistakes/pull/2544)
1718
- Strip trailing whitespace in `seo_description`. [#2542](https://github.com/mmistakes/minimal-mistakes/pull/2542)
1819
- Improve sticky sidebar's appearance with short content. [#2514](https://github.com/mmistakes/minimal-mistakes/pull/2514)

0 commit comments

Comments
 (0)
Please sign in to comment.