Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: coreos/coreos-assembler
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: jbtrystram/coreos-assembler
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: schema-multi-images
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 5 files changed
  • 1 contributor

Commits on Mar 27, 2025

  1. schema: support multiple images destinations 

    In coreos/fedora-coreos-pipeline#1091 we added
the possibility of publishing container images to multiples repositories.

This needs to be reflected in the schema otherwhise we only record one
image (currenlty the last pushed).

Add a `primary-image` key that extends image by adding an `additional-images`
array.

Use that for relevant container images objects.

See coreos/fedora-coreos-pipeline#1099
    @jbtrystram
    jbtrystram committed Mar 27, 2025
    Copy the full SHA
    fb222e2 View commit details

  2. cmd/push-container-manifest: use additional-images rather than overwrite 

    in coreos/fedora-coreos-pipeline#1091 we started
publishing container images in multiples repos.
However the build.json was not reflecting that, only storing the last
pushed image data, overwriting it with each arch.

See #4038
See coreos/fedora-coreos-pipeline#1099
    @jbtrystram
    jbtrystram committed Mar 27, 2025
    Copy the full SHA
    c3067b4 View commit details

  3. src/cmd-coreos-prune: update to new schema

    @jbtrystram
    jbtrystram committed Mar 27, 2025
    Copy the full SHA
    b5141f2 View commit details

  4. schema: update generated code with make schema 

    In fb222e2 we introduced additionnal
images in the schema, update the generated go code to match.
    @jbtrystram
    jbtrystram committed Mar 27, 2025
    Loading
    Loading status checks…
    Copy the full SHA
    1e8ac91 View commit details
Loading