Skip to content

Commit 09dc308

Browse files
authored
Merge pull request backstage#14061 from agentbellnorm/pass-catalog-client-to-techdocs-router
[TechDocs] Pass catalog client to techdocs router
2 parents 847caff + 847eb6f commit 09dc308

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@backstage/plugin-techdocs-backend': minor
3+
---
4+
5+
Add optional `catalogClient` argument to `createRoute` parameters

plugins/techdocs-backend/api-report.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
/// <reference types="node" />
77

88
import { CatalogApi } from '@backstage/catalog-client';
9+
import { CatalogClient } from '@backstage/catalog-client';
910
import { Config } from '@backstage/config';
1011
import { DocumentCollatorFactory } from '@backstage/plugin-search-common';
1112
import { Entity } from '@backstage/catalog-model';
@@ -79,6 +80,7 @@ export type OutOfTheBoxDeploymentOptions = {
7980
cache: PluginCacheManager;
8081
docsBuildStrategy?: DocsBuildStrategy;
8182
buildLogTransport?: winston.transport;
83+
catalogClient?: CatalogClient;
8284
};
8385

8486
// @public
@@ -90,6 +92,7 @@ export type RecommendedDeploymentOptions = {
9092
cache: PluginCacheManager;
9193
docsBuildStrategy?: DocsBuildStrategy;
9294
buildLogTransport?: winston.transport;
95+
catalogClient?: CatalogClient;
9396
};
9497

9598
// @public

plugins/techdocs-backend/src/service/router.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ export type OutOfTheBoxDeploymentOptions = {
5858
cache: PluginCacheManager;
5959
docsBuildStrategy?: DocsBuildStrategy;
6060
buildLogTransport?: winston.transport;
61+
catalogClient?: CatalogClient;
6162
};
6263

6364
/**
@@ -74,6 +75,7 @@ export type RecommendedDeploymentOptions = {
7475
cache: PluginCacheManager;
7576
docsBuildStrategy?: DocsBuildStrategy;
7677
buildLogTransport?: winston.transport;
78+
catalogClient?: CatalogClient;
7779
};
7880

7981
/**
@@ -107,7 +109,8 @@ export async function createRouter(
107109
): Promise<express.Router> {
108110
const router = Router();
109111
const { publisher, config, logger, discovery } = options;
110-
const catalogClient = new CatalogClient({ discoveryApi: discovery });
112+
const catalogClient =
113+
options.catalogClient ?? new CatalogClient({ discoveryApi: discovery });
111114
const docsBuildStrategy =
112115
options.docsBuildStrategy ?? DefaultDocsBuildStrategy.fromConfig(config);
113116
const buildLogTransport =

0 commit comments

Comments
 (0)