Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for assets in Parcel example app #994

Closed
y-nk opened this issue Mar 18, 2021 · 0 comments
Closed

support for assets in Parcel example app #994

y-nk opened this issue Mar 18, 2021 · 0 comments
Labels
scope: templates Related to an init template, not necessarily to core (but could influence core)

Comments

@y-nk
Copy link

y-nk commented Mar 18, 2021

Current Behavior

In a tsdx react/storybook project, you may want to add fonts or images with your components. With the proper loader as explained here, you can easily include your assets. For fonts, you can "tree shake" the inclusion with imports, like import RegularFont from 'regularFont.ttf', build along a @font-face css block with url(${regularFont}) and it will compile nicely.

The problem is that the example app works with parcel and so assets aren't shipped.
I expect this will be a similar issue with npm link workflow for working in tandem with other projects.

Expected behavior

Static assets should be loaded as well im example app.

Suggested solution(s)

Not sure.

Additional context

I reckon is this side effect of tsdx and not really a direct issue of the package, but... yeah. I think a lot of people would definitely be interested in an answer/solution.

Your environment

  System:
    OS: macOS 11.2.3
    CPU: (8) x64 Intel(R) Core(TM) i5-8257U CPU @ 1.40GHz
    Memory: 385.52 MB / 8.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 15.0.1 - ~/.nvm/versions/node/v15.0.1/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.10 - ~/.nvm/versions/node/v15.0.1/bin/npm
  Browsers:
    Chrome: 89.0.4389.90
    Firefox: 84.0.1
    Safari: 14.0.3
  npmPackages:
    tsdx: ^0.14.1 => 0.14.1
    typescript: ^4.2.3 => 4.2.3
@agilgur5 agilgur5 changed the title [React/Storybook] [example app] support for example project + embedded assets support for assets in Parcel example app Mar 19, 2021
@agilgur5 agilgur5 added the scope: templates Related to an init template, not necessarily to core (but could influence core) label Mar 19, 2021
@y-nk y-nk closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: templates Related to an init template, not necessarily to core (but could influence core)
Projects
None yet
Development

No branches or pull requests

2 participants