Incorrect Guarantee Statistics

[emielsebastiaan]

Incorrect Guarantee Statistics

We found an inconsistency between our [{PyJAMaz}] implementation and the JAM-Duna implementation in the test data for the Assurances mode.
Reference:

jamtestnet/data/assurances/state_snapshots/1_003.json

Line 554 in 5e0f5c4

"guarantees": 1,

Analysis

The block has a work-report which is verifiably guaranteed by 3 validators. Hence 3 validators should get their guarantee statistic increased (and not only 1 as per jam-duna data).
We suspect an incorrect implementation of GP-0.6.2-eq:13.4 in JAM Duna, in which statistics are stored based on the author index of the block and not based on the Reporters-set.

Difference

JAM Duna Data

[
  {
    "assurances": 0,
    "blocks": 0,
    "guarantees": 0,
    "pre_images": 0,
    "pre_images_size": 0,
    "tickets": 0
  },
  {
    "assurances": 0,
    "blocks": 0,
    "guarantees": 0,
    "pre_images": 0,
    "pre_images_size": 0,
    "tickets": 0
  },
  {
    "assurances": 0,
    "blocks": 0,
    "guarantees": 0,
    "pre_images": 0,
    "pre_images_size": 0,
    "tickets": 0
  },
  {
    "assurances": 0,
    "blocks": 0,
    "guarantees": 0,
    "pre_images": 0,
    "pre_images_size": 0,
    "tickets": 0
  },
  {
    "assurances": 0,
    "blocks": 3,
    "guarantees": 0,
    "pre_images": 0,
    "pre_images_size": 0,
    "tickets": 6
  },
  {
    "assurances": 0,
    "blocks": 1,
    "guarantees": 1,
    "pre_images": 0,
    "pre_images_size": 0,
    "tickets": 3
  }
]

[{PyJAMaz}] Data

[
  {
    "assurances": 0, 
    "blocks": 0, 
    "guarantees": 0, 
    "pre_images": 0, 
    "pre_images_size": 0, 
    "tickets": 0
  }, 
  {
    "assurances": 0, 
    "blocks": 0, 
    "guarantees": 1, 
    "pre_images": 0, 
    "pre_images_size": 0, 
    "tickets": 0
  }, 
  {
    "assurances": 0, 
    "blocks": 0, 
    "guarantees": 1, 
    "pre_images": 0, 
    "pre_images_size": 0, 
    "tickets": 0
  }, 
  {
    "assurances": 0, 
    "blocks": 0, 
    "guarantees": 1, 
    "pre_images": 0, 
    "pre_images_size": 0, 
    "tickets": 0
  }, 
  {
    "assurances": 0, 
    "blocks": 3, 
    "guarantees": 0, 
    "pre_images": 0, 
    "pre_images_size": 0, 
    "tickets": 6
  }, 
  {
    "assurances": 0, 
    "blocks": 1, 
    "guarantees": 0, 
    "pre_images": 0, 
    "pre_images_size": 0, 
    "tickets": 3
  }
]

[sourabhniyogi]

You are correct, will fix!

[sourabhniyogi]

We now have 3 validators incrementing due to their guaranteeing, not 1 due to including 1 guarantee with 3 signatures

[sourabhniyogi]

Addressed in 0.6.2.2