Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error condition for useless ticket not checked: gamma_a #52

Closed
ggwpez opened this issue Feb 13, 2025 · 2 comments
Closed

Error condition for useless ticket not checked: gamma_a #52

ggwpez opened this issue Feb 13, 2025 · 2 comments

Comments

@ggwpez
Copy link

ggwpez commented Feb 13, 2025

The last ticket in block 1_006 does not end up in the post state gamma_a', which is an error according to the Gray Paper. The block should therefore not be importable.

Pre state gamma_a

[
    "0B7537993B0A700DEF26BB16E99ED0BFB530F616E4C13CF63ECB60BCBE83387D",
    "1912BAA74049A4CAD89DC3F0646144459B691B926CF8B9C1C4A5BBFA1EE0C331",
    "23BD628FD365A0F3ECD10DB746DD04EC5EFE61F96DA19AE070C44B97D3C9A7B8",
    "31D6A25525FF4BD6E47E611646D7B5835B94B5C0A69C225371B2B762C93095A2",
    "31E9B8070F42D7C9083ECA5879E5528191259A395761B8FCC068DCDD36B06BE4",
    "39120D5B82981C7F5ABA8247925F358AFB9539839B61602A0726F51EFB35EF4C",
    "39E2D23807FF3788156EAC40CC0A622A9FD23E9468BF962AEBE48079C0FD2F1A",
    "39F7D99B86F90CADA4AA3B08ADFE310024813FCA0BDCDFF944873A2CC2E47074",
    "665DF13FD353FFE92E9BD68AE952F4511681F04BD2FFB9A6DA1B1F5F706C53EC",
    "6B5CC620ED50042CD517EC8267706C82482F07EBCB3C65BFB6288EF5984141A7",
    "7914D0DC71014A8106875C440EC79DC8358EF5E65700F8780F0AF56D317314E0",
    "7A2F3858EA30857F774547A9E73BB7DAD0D30D908EA09DDBC2BCE6B5823A630A"
]

Submitted tickets scores

[
    "22FDCFA858E5195E222174597D7D33BD66D97748C413B876F7A132134CE9BAEF",
    "71DD32FB8A1580B4AA3213C3616D8FBBCB9EDC00467C4E4548FF8A1FD815811C",
    "8723F7316136044EEE10391636CEED02F674A615AE035F624B15B8DCF6A3BDBD" # missing from gamma_a'
]

Post state gamma_a'

[
    "0B7537993B0A700DEF26BB16E99ED0BFB530F616E4C13CF63ECB60BCBE83387D",
    "1912BAA74049A4CAD89DC3F0646144459B691B926CF8B9C1C4A5BBFA1EE0C331",
    "22FDCFA858E5195E222174597D7D33BD66D97748C413B876F7A132134CE9BAEF", # ticket 1
    "23BD628FD365A0F3ECD10DB746DD04EC5EFE61F96DA19AE070C44B97D3C9A7B8",
    "31D6A25525FF4BD6E47E611646D7B5835B94B5C0A69C225371B2B762C93095A2",
    "31E9B8070F42D7C9083ECA5879E5528191259A395761B8FCC068DCDD36B06BE4",
    "39120D5B82981C7F5ABA8247925F358AFB9539839B61602A0726F51EFB35EF4C",
    "39E2D23807FF3788156EAC40CC0A622A9FD23E9468BF962AEBE48079C0FD2F1A",
    "39F7D99B86F90CADA4AA3B08ADFE310024813FCA0BDCDFF944873A2CC2E47074",
    "665DF13FD353FFE92E9BD68AE952F4511681F04BD2FFB9A6DA1B1F5F706C53EC",
    "6B5CC620ED50042CD517EC8267706C82482F07EBCB3C65BFB6288EF5984141A7",
    "71DD32FB8A1580B4AA3213C3616D8FBBCB9EDC00467C4E4548FF8A1FD815811C" # ticket 2
]
@yoyo2325
Copy link
Collaborator

Thanks, @ggwpez!
That helps a lot. We missed this.
So basically, we have to predict almost every state in Safrole for block production

@ggwpez
Copy link
Author

ggwpez commented Feb 13, 2025

fixed

@ggwpez ggwpez closed this as completed Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants