Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accumulated #50

Closed
danicuki opened this issue Feb 12, 2025 · 4 comments
Closed

Accumulated #50

danicuki opened this issue Feb 12, 2025 · 4 comments
Assignees

Comments

@danicuki
Copy link
Contributor

Found another discrepancy between your json and w3f: "xi": it is only a list of lists of hashes:

"xi": [
            [],
            [],
            [],
            [],
            [],
            [],
            [],
            [],
            [],
            [
                "0x04f5f2b6509d847d49487d5db1275e8105225018952c7aec9d2d90f039c50e45"
            ],
            [
                "0x506524cb141b83715705c05983d17ebc7760c64d2ce81f15b6bc2dd1eeb55551"
            ],
            [
                "0x7bbdd7961afb2db642f7cdb87021fb053c67d2ac79d69a87fc9fbcf6786e30b9"
            ]

instead of

"xi": [
        {
            "work_package_hash": null
        }
...]
@mkchungs mkchungs self-assigned this Feb 12, 2025
@jam-duna jam-duna deleted a comment from sourabhniyogi Feb 12, 2025
@sourabhniyogi
Copy link
Contributor

I now understand you want the first format and not the second, will align on that

AccumulatedQueueItem ::= SEQUENCE OF WorkPackageHash
AccumulatedQueue ::= SEQUENCE (SIZE(epoch-length)) OF AccumulatedQueueItem

@sourabhniyogi
Copy link
Contributor

We are able to JSON serialize to the first format and will publish an update very soon.

@mkchungs
Copy link
Collaborator

Addressed in #53, #54

@sourabhniyogi
Copy link
Contributor

@danicuki We have published xi consistently:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants