Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Well-balanced tree on empty list input #49

Closed
emielsebastiaan opened this issue Feb 12, 2025 · 4 comments
Closed

Well-balanced tree on empty list input #49

emielsebastiaan opened this issue Feb 12, 2025 · 4 comments
Assignees

Comments

@emielsebastiaan
Copy link

emielsebastiaan commented Feb 12, 2025

We have found an inconsistency between the testnet data by Jam-Duna and our implementation [{PyJAMaz}].
This is related to the implementation of GP-0.6.2-eq:7.3 and especially variable r.

Difference

"jam-duna_value": "0xbc36789e7a1e281436464229828f817d6612f7b477d66591ff96a9e064bcc98a"
"pyjamaz_value": "0x0000000000000000000000000000000000000000000000000000000000000000",

Suspected causes

JamDuna creates a Keccak-hash over payload '0x00', while we suspect an empty list should be input into the well-balanced tree (GP-0.6.2-eq:E.2), which in turn calls function N (GP-0.6.2-eq:E.1). For an empty list (|v|=0) the zero-hash should be the output.

References

@sourabhniyogi
Copy link
Contributor

sourabhniyogi commented Feb 12, 2025

Thank you, will study! ==> we have studied and agree with you, will publish soon!

@charliewinston14
Copy link

Reported the same issue here #36

@sourabhniyogi
Copy link
Contributor

@emielsebastiaan Can you kindly check this issue is still present in this recent commit? Thank you!

@sourabhniyogi sourabhniyogi self-assigned this Feb 14, 2025
@sourabhniyogi
Copy link
Contributor

Closing this based on @charliewinston14 comment here -- thank you for the detailed report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants