Skip to content

Commit fc51047

Browse files
malfetfacebook-github-bot
authored andcommittedSep 9, 2020
Small fixes in Dependency.cmake and run_test.py (pytorch#44414)
Summary: Do not add gencode flags to NVCC_FLAGS twice: First time they are added in `cmake/public/cuda.cmake` no need to do it again in `cmake/Dependencies.cmake` Copy `additional_unittest_args` before appending local options to it in `run_test()` method Pull Request resolved: pytorch#44414 Reviewed By: seemethere Differential Revision: D23605733 Pulled By: malfet fbshipit-source-id: 782a0da61650356a978a892fb03c66cb1a1ea26b
1 parent b0bcdbb commit fc51047

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed
 

‎cmake/Dependencies.cmake

-1
Original file line numberDiff line numberDiff line change
@@ -1501,7 +1501,6 @@ if(NOT INTERN_BUILD_MOBILE)
15011501
endif()
15021502

15031503
list(APPEND CUDA_NVCC_FLAGS ${TORCH_NVCC_FLAGS})
1504-
list(APPEND CUDA_NVCC_FLAGS ${NVCC_FLAGS_EXTRA})
15051504
if(CMAKE_POSITION_INDEPENDENT_CODE AND NOT MSVC)
15061505
list(APPEND CUDA_NVCC_FLAGS "-Xcompiler" "-fPIC")
15071506
endif()

‎test/run_test.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ def get_executable_command(options, allow_pytest):
217217

218218

219219
def run_test(test_module, test_directory, options, launcher_cmd=None, extra_unittest_args=None):
220-
unittest_args = options.additional_unittest_args
220+
unittest_args = options.additional_unittest_args.copy()
221221
if options.verbose:
222222
unittest_args.append('--verbose')
223223
if test_module in RUN_PARALLEL_BLOCKLIST:

0 commit comments

Comments
 (0)