Skip to content

Commit 106459a

Browse files
rohan-varmafacebook-github-bot
authored andcommittedSep 9, 2020
Rename test_distributed to test_distributed_fork (pytorch#42932)
Summary: Pull Request resolved: pytorch#42932 Follow up from pytorch#41769, rename `test_distributed` to `test_distributed_fork` to make it explicit that it forks. New command to run test: `python test/run_test.py -i distributed/test_distributed_fork -v` ghstack-source-id: 111632568 Test Plan: `python test/run_test.py -i distributed/test_distributed_fork -v` Reviewed By: izdeby Differential Revision: D23072201 fbshipit-source-id: 48581688b6c5193a309e803c3de38e70be980872
1 parent b22abbe commit 106459a

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed
 

‎.jenkins/pytorch/multigpu-test.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ fi
2929

3030
python tools/download_mnist.py --quiet -d test/cpp/api/mnist
3131
OMP_NUM_THREADS=2 TORCH_CPP_TEST_MNIST_PATH="test/cpp/api/mnist" build/bin/test_api
32-
time python test/run_test.py --verbose -i distributed/test_distributed
32+
time python test/run_test.py --verbose -i distributed/test_distributed_fork
3333
time python test/run_test.py --verbose -i distributed/test_c10d
3434
time python test/run_test.py --verbose -i distributed/test_c10d_spawn
3535
assert_git_not_dirty
File renamed without changes.

‎test/run_test.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
'test_cuda_primary_ctx',
3535
'test_dataloader',
3636
'distributed/test_data_parallel',
37-
'distributed/test_distributed',
37+
'distributed/test_distributed_fork',
3838
'distributed/test_distributed_spawn',
3939
'test_distributions',
4040
'test_expecttest',
@@ -96,7 +96,7 @@
9696
'distributed/rpc/test_faulty_agent',
9797
'distributed/rpc/test_process_group_agent',
9898
'distributed/rpc/test_tensorpipe_agent',
99-
'distributed/test_distributed',
99+
'distributed/test_distributed_fork',
100100
'distributed/test_distributed_spawn',
101101
]
102102

@@ -140,7 +140,7 @@
140140
'test_jit_profiling',
141141
'test_torch',
142142
'distributed/nn/jit/test_instantiator',
143-
'distributed/test_distributed',
143+
'distributed/test_distributed_fork',
144144
'distributed/rpc/test_process_group_agent',
145145
'distributed/rpc/test_tensorpipe_agent',
146146
'distributed/algorithms/ddp_comm_hooks/test_ddp_hooks',
@@ -319,7 +319,7 @@ def test_distributed(test_module, test_directory, options):
319319
os.environ['INIT_METHOD'] = 'env://'
320320
os.environ.update(env_vars)
321321
if with_init_file:
322-
if test_module in ["test_distributed", "test_distributed_spawn"]:
322+
if test_module in ["test_distributed_fork", "test_distributed_spawn"]:
323323
init_method = 'file://{}/'.format(tmp_dir)
324324
else:
325325
init_method = 'file://{}/shared_init_file'.format(tmp_dir)
@@ -351,7 +351,7 @@ def test_distributed(test_module, test_directory, options):
351351
'test_cuda_primary_ctx': test_cuda_primary_ctx,
352352
'test_cpp_extensions_aot_no_ninja': test_cpp_extensions_aot_no_ninja,
353353
'test_cpp_extensions_aot_ninja': test_cpp_extensions_aot_ninja,
354-
'distributed/test_distributed': test_distributed,
354+
'distributed/test_distributed_fork': test_distributed,
355355
'distributed/test_distributed_spawn': test_distributed,
356356
}
357357

‎test/test_determination.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ class DeterminationTest(unittest.TestCase):
1616
"test_jit_profiling",
1717
"test_jit",
1818
"test_torch",
19-
"distributed/test_distributed",
19+
"distributed/test_distributed_fork",
20+
"distributed/test_distributed_spawn",
2021
"distributed/rpc/test_process_group_agent",
2122
"test_cpp_extensions_aot_ninja",
2223
"test_cpp_extensions_aot_no_ninja",
@@ -108,7 +109,7 @@ def test_torch_file(self):
108109
self.assertEqual(
109110
self.determined_tests(["torch/utils/cpp_extension.py"]),
110111
[
111-
"distributed/test_distributed",
112+
"distributed/test_distributed_fork",
112113
"test_cpp_extensions_aot_ninja",
113114
"test_cpp_extensions_aot_no_ninja",
114115
"test_determination",

0 commit comments

Comments
 (0)
Please sign in to comment.